Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Loading: Allow absolute paths #242

Closed
wants to merge 6 commits into from

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jan 23, 2019

Addresses an issue in #225 where absolute paths aren't loaded properly (we always prepend the working directory, today!)

TODO:

  • Verify in WebGL strategy
  • Update lockfile
  • Clean up

@bryphe bryphe changed the title [WIP] Asset Loading: Allow absolute paths Asset Loading: Allow absolute paths Jan 23, 2019
@OhadRau
Copy link
Collaborator

OhadRau commented Jan 23, 2019

Question: Would ~/x register as an absolute path in this case? I think it would be best if we could replicate the behavior of path resolution on the command line, so if that doesn't count as an absolute path we might want to look at a different approach.

@akinsho
Copy link
Member

akinsho commented Feb 6, 2019

@bryphe @OhadRau maybe you could execute an echo command using Unix.open_process_in tested this out and the shell expands it. Other than a module that would do that for you the only way to get that kind of expansion is from calling out to a shell, I don't think its necessarily a blocker here but something that can be added on top or afterwards? 🤷‍♂️

@bryphe
Copy link
Member Author

bryphe commented Aug 26, 2019

Superseded by #545

@bryphe bryphe closed this Aug 26, 2019
@Et7f3 Et7f3 deleted the bryphe/bugfix/only-prepend-if-relative branch May 6, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants