Load image from absolute path/url

[baransu]

Trying to display images from URL I found it's currently not supported. I decided to download images to some tmp directory and use an absolute path as an Image src. And that's also not supported right now:

revery/src/Draw/ImageRenderer.re

Line 25 in aa2051c

let relativeImagePath = execDir ++ imagePath;

The best option would be to have:

type src = Url(string) | Relative(string) | Absolute(string)

which would allow loading images from /assets, any directory and URL.

I'm willing to help with that feature but I don't know what's the best approach to download image and use it as a texture in ImageRenderer.

[bryphe]

Trying to display images from URL I found it's currently not supported.

Yes, this is something I'd like to have... I started a fetch-like API for Revery but haven't had time to finish it. It'd be great to get that working, and then hook up our asset resolution to detect URLs and use that automatically.

I decided to download images to some tmp directory and use an absolute path as an Image src.

Good idea as a workaround for now! I had a PR a while back for absolute paths (#242 ) but didn't finish it. I ported it over to #545 now. It's more naive - just uses a string as opposed to a variant, but I think it's OK for now (at least a step forward from what we have).

We could look at integrating the Path module here, which has a more similar API to what you proposed.

[lessp]

Regarding URL I experimented a bit with this yesterday and got a PoC working. May be happy to take a stab at it, depending on what you are seeing!

My "get-something-running" approach was to save the images to a temporary folder, escape the url from any illegal characters and then provide that path to the renderer.

Some questions I had:

• Do we delete temporary cached images on application-close?
• Where do we store the temporary files? Might be platform-specific

There are probably other approaches which may be more suited, just leaving this here since I at least did some experimenting! 🙂

[Et7f3]

Maybe let the user decide with Url(string, option(string)) and the second argument if None mean non-cached and Some(cachedPath) mean to save file to cachedPath. And provide cleaning functions: cleanAll, cleanOneFile.