Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove version lock of @faker-js/faker [PLAT-2487] #85

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix: remove version lock of @faker-js/faker [PLAT-2487] #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@
"matchPackageNames": ["faker", "@types/faker"],
"enabled": false
},
{
"description": "Skip @faker-js/faker update to v7 (since it is ESM) [PLAT-2487]",
"matchPackageNames": ["@faker-js/faker"],
"allowedVersions": "<=6.3.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be fine for our UIs but won't this be problematic for services that are not ESM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identity-service is already on v7 and there doesn't seem to be an issue there: https://github.com/reside-eng/identity-service/blob/main/package.json#L71

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's drop this then.

},
{
"description": "node-config library and types",
"matchPackageNames": ["config", "@types/config"],
Expand Down