fix: remove version lock of @faker-js/faker [PLAT-2487] #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
requested review from
hershmire and
mathieudi
and removed request for
a team
hershmire
reviewed
Oct 11, 2024
| { | ||
| "description": "Skip @faker-js/faker update to v7 (since it is ESM) [PLAT-2487]", | ||
| "matchPackageNames": ["@faker-js/faker"], | ||
| "allowedVersions": "<=6.3.1" |
There was a problem hiding this comment.
It might be fine for our UIs but won't this be problematic for services that are not ESM?
There was a problem hiding this comment.
Identity-service is already on v7 and there doesn't seem to be an issue there: https://github.com/reside-eng/identity-service/blob/main/package.json#L71
There was a problem hiding this comment.
Okay, let's drop this then.
prescottprue
changed the title
hershmire
approved these changes
Oct 11, 2024
|
I was also able to update core-functions to v9 of faker without issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ TICKET-000
Upstream PRs
Downstream PRs
Changes
Admin-ui is on v8 with no issues - this skip doesn't seem relevant anymroe
Notes for Reviewers
Recordings/Screenshots