Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exceptions; Add IsGranted; Annotate package id; Add docs url #272

Merged
merged 3 commits into from
Sep 11, 2020

Conversation

karniv00l
Copy link
Contributor

@karniv00l karniv00l commented Sep 11, 2020

Screenshot 2020-09-11 at 12 19 42

@karniv00l karniv00l requested a review from akondas September 11, 2020 10:19
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #272 into rest-api-rebased will decrease coverage by 0.11%.
The diff coverage is 62.50%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             rest-api-rebased     #272      +/-   ##
======================================================
- Coverage               99.82%   99.71%   -0.12%     
- Complexity               1792     1793       +1     
======================================================
  Files                     284      284              
  Lines                    5224     5231       +7     
======================================================
+ Hits                     5215     5216       +1     
- Misses                      9       15       +6     
Impacted Files Coverage Δ Complexity Δ
src/Controller/Api/PackageController.php 100.00% <ø> (ø) 38.00 <0.00> (ø)
src/Service/Symfony/ApiExceptionListener.php 60.00% <50.00%> (-40.00%) 5.00 <0.00> (+1.00) ⬇️
src/Controller/Api/ApiController.php 100.00% <100.00%> (ø) 15.00 <0.00> (ø)
src/Security/ApiTokenAuthenticator.php 100.00% <100.00%> (ø) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14ff06...4b9a198. Read the comment docs.

@akondas akondas merged commit 51f7872 into repman-io:rest-api-rebased Sep 11, 2020
akondas pushed a commit that referenced this pull request Sep 11, 2020
#272)

* Catch all exceptions; Add IsGranted; Annotate package id; Add docs url

* Update docs link

* Simplify exception listener
akondas added a commit that referenced this pull request Sep 14, 2020
* REST API implementation (#269)

* Catch all exceptions; Add IsGranted; Annotate package id; Add docs url (#272)

* Catch all exceptions; Add IsGranted; Annotate package id; Add docs url

* Update docs link

* Simplify exception listener

* More visible doc link (#273)

* Add API to readme (#274)

Co-authored-by: Piotr Rogowski <[email protected]>
@karniv00l karniv00l deleted the rest-api-rebased-fix branch September 16, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants