Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API implementation (#269) #270

Merged
merged 4 commits into from
Sep 14, 2020
Merged

REST API implementation (#269) #270

merged 4 commits into from
Sep 14, 2020

Conversation

akondas
Copy link
Member

@akondas akondas commented Sep 10, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #270 into master will decrease coverage by 0.08%.
The diff coverage is 99.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
- Coverage     99.80%   99.71%   -0.09%     
- Complexity     1542     1793     +251     
============================================
  Files           253      284      +31     
  Lines          4503     5231     +728     
============================================
+ Hits           4494     5216     +722     
- Misses            9       15       +6     
Impacted Files Coverage Δ Complexity Δ
src/Service/Symfony/ApiExceptionListener.php 60.00% <60.00%> (ø) 5.00 <5.00> (?)
src/Controller/Api/ApiController.php 100.00% <100.00%> (ø) 15.00 <15.00> (?)
src/Controller/Api/OrganizationController.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
src/Controller/Api/PackageController.php 100.00% <100.00%> (ø) 38.00 <38.00> (?)
src/Controller/Api/TokenController.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/Controller/OrganizationController.php 100.00% <100.00%> (ø) 41.00 <2.00> (ø)
src/Controller/UserController.php 100.00% <100.00%> (ø) 18.00 <6.00> (+6.00)
src/Entity/User.php 100.00% <100.00%> (ø) 41.00 <7.00> (+7.00)
src/Entity/User/ApiToken.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
src/Form/Type/Api/AddPackageType.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 671beda...3432a4c. Read the comment docs.

#272)

* Catch all exceptions; Add IsGranted; Annotate package id; Add docs url

* Update docs link

* Simplify exception listener
@akondas akondas merged commit dee7f73 into master Sep 14, 2020
@akondas akondas deleted the rest-api-rebased branch September 14, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants