Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-serve): handle os signals by closing dev server #2528

Merged
merged 9 commits into from
Apr 7, 2022
Merged

fix(remix-serve): handle os signals by closing dev server #2528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4369805
chore(cla): sign and sort cla list
andrewbrey Mar 28, 2022
3624275
fix(remix-serve): handle os interruption signals by closing down the …
andrewbrey Mar 28, 2022
e3fb96b
refactor(signals): use forEach instead of for-of per review feedback
andrewbrey Mar 30, 2022
d27c95b
refactor(cli): use ternary instead of if-else per review feedback
andrewbrey Mar 30, 2022
e6c8b6f
Merge branch 'dev' into fix/handle-os-signals
andrewbrey Apr 2, 2022
f4a64df
Merge branch 'dev' into fix/handle-os-signals
andrewbrey Apr 5, 2022
6e82398
Merge branch 'dev' into fix/handle-os-signals
andrewbrey Apr 6, 2022
ebfd56a
Merge branch 'dev' into fix/handle-os-signals
andrewbrey Apr 6, 2022
4a4cb71
Merge branch 'dev' into fix/handle-os-signals
andrewbrey Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- alex-ketch
- alexuxui
- andrelandgraf
- andrewbrey
- AndrewIngram
- anishpras
- anmolm96
Expand Down Expand Up @@ -254,10 +255,10 @@
- robindrost
- roddds
- RomanSavarin
- rossipedia
- RossJHagan
- RossMcMillan92
- rowinbot
- rossipedia
- rphlmr
- rtabulov
- ruisaraiva19
Expand Down
11 changes: 6 additions & 5 deletions packages/remix-serve/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ let onListen = () => {
};

let app = createApp(buildPath);
let server = process.env.HOST
? app.listen(port, process.env.HOST, onListen)
: app.listen(port, onListen);

if (process.env.HOST) {
app.listen(port, process.env.HOST, onListen);
} else {
app.listen(port, onListen);
}
["SIGTERM", "SIGINT"].forEach((signal) => {
process.once(signal, () => server?.close(console.error));
});