fix(remix-serve): handle os signals by closing dev server #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
requested changes
Mar 29, 2022
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
@MichaelDeBoey I've pushed up changes for each of your two feedback items - let me know if you have anything else on this one! |
MichaelDeBoey
approved these changes
Mar 30, 2022
Co-authored-by: Michaël De Boey <[email protected]>
machour
approved these changes
Apr 1, 2022
|
Thank you for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple signal handlers to the
remix-servecli that will close down the dev server if it receives either aTERMorINToperating system signal. In the case of a failed shutdown of the dev server, log to stderr.