-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-4326] Async ComputedVar #4711
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3d50c1b
WiP
masenf 3da6426
Save the var from get_var_name
masenf 14c8aa4
Merge remote-tracking branch 'origin/main' into masenf/async-computed…
masenf ca3c0fd
flatten StateManagerRedis.get_state algorithm
masenf 5143d74
Get all the states in a single redis round-trip
masenf 8f4b12d
update docstrings in StateManagerRedis
masenf aa5b303
Move computed var dep tracking to separate module
masenf e74e913
Fix pre-commit issues
masenf 25456a5
ComputedVar.add_dependency: explicitly dependency declaration
masenf 213307c
Merge remote-tracking branch 'origin/main' into masenf/async-computed…
masenf 0aad416
Fix/ignore more pyright issues from recent merge
masenf c30e725
handle cleaning out _potentially_dirty_states on reload
masenf 8f6dfde
ignore accessed attributes missing on state class
masenf 534d38c
fix playwright tests, which insist on running an asyncio loop
masenf c7fc787
Merge branch 'main' into masenf/async-computed-var
adhami3310 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to abstract this logic beyond being specific to app harness? is it possible to detect that an event loop running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's possible to detect it (which is what we're doing just above), but that would be abnormal conditions for a reflex app outside of a testing environment, so maybe we want to fail on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an error sounds fine then, if someone complains we will learn something 🤓