[ENG-4326] Async ComputedVar #4711
Merged
+1,091
−492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify fetching of states and avoid repeatedly fetching the same state
Allow var dependencies to be added at runtime, for example, when defining a ComponentState that depends on vars that cannot be known statically. Fix more pyright issues.
these might be added dynamically later in which case we recompute the dependency tracking dicts... if not, they'll blow up anyway at runtime.
adhami3310
reviewed
Jan 31, 2025
| except RuntimeError: | ||
| pass | ||
| else: | ||
| if is_in_app_harness(): |
There was a problem hiding this comment.
is it possible to abstract this logic beyond being specific to app harness? is it possible to detect that an event loop running?
There was a problem hiding this comment.
it's possible to detect it (which is what we're doing just above), but that would be abnormal conditions for a reflex app outside of a testing environment, so maybe we want to fail on it?
There was a problem hiding this comment.
an error sounds fine then, if someone complains we will learn something 🤓
CodSpeed Performance ReportMerging #4711 will not alter performanceComparing Summary
|
adhami3310
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rx.varcan now decorate anasyncfunction (Accessing the var on the instance requiresawait)_var_dependencieson other statesStateManagerRedisget_stateroutine to accomodate fetching of arbitrary state dependenciesget_statemethod..add_dependencyonComputedVarto allow compile time dynamic dependency specificationFixes #4022