Make Vite the default bundler #8301

dac09 · 2023-05-12T10:15:17Z

This PR does the following:

makes Vite the default bundler
updates CRWA TS template to have Vite setup
updates CRWA JS template to have Vite setup
rebuilds the fixture Vite preconfigured
Vite specific files are now accessible via getPaths in rw/project-config
⚠️ breaks SVG handling, so it now works in the default Vite way instead of using svg components (which is fragile and confusing to users, see [RFC]: Univerzal image component #8291)

Todo

Unable to use the vite dev server in Gitpod for reviewing PRs
~~This probably is just a small config tweak, but not sure what it is.~~
Failing Windows smoke test with Playwright
~~This is likely the same issue, accessing the port via Playwright.~~

* 'main' of github.com:redwoodjs/redwood: fix(deps): update dependency @heroicons/react to v2.0.18 (redwoodjs#8277) chore(release): publish in two steps for lock file chore(deps): update dependency glob to v10.2.3 (redwoodjs#8275) chore(deps): update dependency nx to v16.1.4 (redwoodjs#8276) Fix --rebuildFixture (redwoodjs#8273) chore(release): update command for crwa templates chore(crwa test, release process): handle yarn.lock chore(Nx): change @nrwl/nx-cloud to nx-cloud (redwoodjs#8272) fix(graphql-server): Display correct plugin name in error message (redwoodjs#8271) chore(cli): Consistent use of util functions within experimental commands (redwoodjs#8268) Draw only at start and end when dealing with non-tty (redwoodjs#8265) fix(deps): update prisma monorepo to v4.14.0 (redwoodjs#8269) fix(deps): update dependency webpack-cli to v5.1.1 (redwoodjs#8266)

…te-default * 'main' of github.com:redwoodjs/redwood: (23 commits) fix: remove react 17/18 warning (redwoodjs#8300) chore(release): tolerate lerna publish faliure Recover lost connection (redwoodjs#8284) chore(deps): update dependency @faker-js/faker to v8 (redwoodjs#8296) chore(release): better git commits during release feat: experimental - Studio Overview and Performance Widgets (redwoodjs#8292) fix(forms): disable webpack-dev-server overlay (redwoodjs#8298) Fix studio lint warning (redwoodjs#8297) Fastify server: Default to localhost (redwoodjs#8019) Fix GraphQL proxy in dev environments without IPv6 (redwoodjs#8233) fix(deps): update dependency @graphiql/plugin-explorer to v0.1.18 (redwoodjs#8290) chore(deps): update dependency supertokens-auth-react to v0.32.3 (redwoodjs#8289) Add `setup sentry` command (redwoodjs#7790) chore: readme update core team and all contributors (redwoodjs#8288) fix(deps): update nivo monorepo to ^0.83.0 (redwoodjs#8286) fix(deps): update dependency babel-plugin-polyfill-corejs3 to v0.8.1 (redwoodjs#8281) chore(deps): update dependency @replayio/playwright to v0.3.30 (redwoodjs#8282) fix(deps): update dependency webpack to v5.82.1 (redwoodjs#8283) Add epilogue to builders (redwoodjs#8285) feat(studio): v2 studio (redwoodjs#8173) ...

Add transform and load for jsx

replay-io · 2023-05-12T10:32:35Z

19 replays were recorded for 58cb10a.

0 Failed

19 Passed

requireAuth graphql checks

useAuth hook, auth redirects checks

locator.waitFor: Target closed
=========================== logs ===========================
waiting for locator('text=Username `[email protected]` already in use') to be visible
============================================================

Check that a specific blog post is prerendered
Check that about is prerendered
Check that homepage is prerendered
Check that meta-tags are rendering the correct dynamic data
Check that rehydration works for page not wrapped in Set
Check that rehydration works for page with Cell in Set
Check that rehydration works for page with code split chunks
Check that you can navigate from home page to specific blog post
Waterfall prerendering (nested cells)
RBAC: Admin user should be able to delete contacts

RBAC: Should not be able to delete contact as non-admin user

locator.waitFor: Target closed
=========================== logs ===========================
waiting for locator('text=Username `[email protected]` already in use') to be visible
============================================================

Smoke test with dev server
Smoke test with rw serve
Loads Cell mocks when Cell is nested in another story
Loads Cell Stories
Loads MDX Stories
Mocks current user, and updates UI while dev server is running

View test run on Replay ↗︎

dac09 · 2023-05-17T10:27:03Z

.gitpod.yml

@@ -23,9 +23,10 @@ tasks:
      cd /workspace/redwood
      yarn install
      yarn run build:test-project ../rw-test-app --typescript --link --verbose
+      cd /workspace/rw-test-app && sed -i "s/\(open *= *\).*/\1false/" redwood.toml


The open flag does not work in Gitpod

…te-default * 'main' of github.com:redwoodjs/redwood: (30 commits) fix(deps): update dependency @vscode/ripgrep to v1.15.3 (redwoodjs#8341) fix(deps): update typescript-eslint monorepo to v5.59.6 (redwoodjs#8335) chore(deps): update dependency vite to v4.3.7 (redwoodjs#8340) fix(deps): update dependency qs to v6.11.2 (redwoodjs#8331) fix(deps): update dependency @tremor/react to v2.6.2 (redwoodjs#8337) chore(deps): update dependency vite to v4.3.6 (redwoodjs#8328) chore(deps): update dependency glob to v10.2.4 (redwoodjs#8326) fix: add back api server for yarn rw dev (redwoodjs#8336) chore(deps): update dependency @faker-js/faker to v8.0.1 (redwoodjs#8330) Disable plugin by default (redwoodjs#8334) fix(deps): update docusaurus monorepo to v2.4.1 (redwoodjs#8329) fix(deps): update dependency react-toastify to v9.1.3 (redwoodjs#8321) chore(deps): update dependency @supabase/supabase-js to v2.22.0 (redwoodjs#8323) fix(deps): update dependency @tremor/react to v2.6.1 (redwoodjs#8320) fix(deps): update dependency listr2 to v6.5.0 (redwoodjs#8317) fix(deps): update dependency semver to v7.5.1 (redwoodjs#8307) fix(deps): update dependency @tremor/react to v2.5.0 (redwoodjs#8306) chore(deps): update dependency @testing-library/dom to v9.3.0 (redwoodjs#8303) chore(deps): update dependency esbuild to v0.17.19 (redwoodjs#8312) chore(deps): update dependency dependency-cruiser to v12.12.2 (redwoodjs#8310) ...

…o feat/make-vite-default * 'feat/make-vite-default' of github.com:dac09/redwood: Modify sed command

dac09 · 2023-05-17T10:40:43Z

packages/vite/bins/rw-vite-dev.mjs

@@ -11,9 +12,25 @@ const startDevServer = async () => {
    throw new Error('Could not locate your web/vite.config.{js,ts} file')
  }

+  // Tries to maintain the same options as vite's dev cli
+  // See here: https://github.com/vitejs/vite/blob/main/packages/vite/src/node/cli.ts#L103
+  // e.g. yarn rw dev web --fwd="--force"


Thoughts on whether --fwd still makes sense? It's mainly useful for passing force, tbh!

When we run yarn rw dev it runs both, so maybe the flag should be webFwd?

This reverts commit 568b0ad.

This reverts commit ab9d0a8.

dac09 · 2023-05-29T06:47:36Z

Thank you for your help with this @jtoar - no way I would've solved it without your help 🤾

tasks/smoke-test/playwright-fixtures/devServer.fixture.ts

.github/actions/setup_test_project/setup_test_project.mjs

Tobbe · 2023-05-29T21:44:34Z

.github/actions/setup_test_project/setup_test_project.mjs

+// const test_project_path = path.join(
+//   os.tmpdir(),
+//   'test-project',
+//   // ":" is problematic with paths
+//   new Date().toISOString().split(':').join('-')
+// )
+


Remove commented code

packages/vite/bins/rw-vite-dev.mjs

dac09 added 9 commits May 10, 2023 11:39

Watch for tsconfig changes

c8ac9dd

Update vite handler, move out experimental confirmation

7ae7004

Add vite file changes to crwa templates (js + ts)

d9cebdd

WIP: probably doesn't work, vite plugin changes

287de46

Fix SVG loading issue, Fix webpack bundler logic, Remove plugin-html

1112ad5

Update fixture with vite

e572d14

Clean up rw-vite-plugin

6cc36cf

Add transform and load for jsx

dac09 added the release:breaking This PR is a breaking change label May 12, 2023

dac09 added 10 commits May 15, 2023 12:18

Fix proejct-config paths and tests for new Vite paths

28905aa

Move vite to dev dependencies

7b8f479

Rebuild fixture

2ad3255

Inline SVGs. NOTE: BREAKING

31375ff

Remove load from jsx plugin

ab9ab7d

Try installing xdg in gitpod

39e8841

Keep the inline svg plugin for prerender

467ae75

Remove inline svg, handle svgs like other images

2ea162a

Disable automatic open in gitpod setup

5c487d1

Modify sed command

0d4866f

dac09 marked this pull request as ready for review May 17, 2023 10:26

dac09 commented May 17, 2023

View reviewed changes

dac09 added 4 commits May 17, 2023 17:31

Update svg type def

0149311

Forward Vite's cli options to dev server

9392a92

Merge branch 'feat/make-vite-default' of github.com:dac09/redwood int…

086127a

…o feat/make-vite-default * 'feat/make-vite-default' of github.com:dac09/redwood: Modify sed command

dac09 commented May 17, 2023

View reviewed changes

dac09 added 2 commits May 17, 2023 19:16

Try limiting workers to 1

3b7e0b5

Merge branch 'main' into feat/make-vite-default

0286add

dac09 and others added 15 commits May 24, 2023 16:01

Merge branch 'main' into feat/make-vite-default

573b45c

Change project copy to use rimraf sync

568b0ad

Revert "Change project copy to use rimraf sync"

955bd4b

This reverts commit 568b0ad.

Merge branch 'main' into feat/make-vite-default

76c16a9

fix(prerender): get vite working on windows

9ff24fa

chore(temp): disable fail fast for debugging

04ec3d5

try bumping timeout and removing replay reporters

bb9820d

test path normalise

ab9d0a8

test remove slash in src

f733bd0

Revert "test path normalise"

d2213a7

This reverts commit ab9d0a8.

revert src slash change

d319a96

revert ci changes (replay disabling)

e447ffe

try local path

dbe2a15

Merge branch 'main' into vite-try-minimal-path

5908e71

Merge branch 'main' into feat/make-vite-default

621b4c6

Merge branch 'main' into feat/make-vite-default

ade2440

Tobbe reviewed May 29, 2023

View reviewed changes

tasks/smoke-test/playwright-fixtures/devServer.fixture.ts Outdated Show resolved Hide resolved

Tobbe reviewed May 29, 2023

View reviewed changes

.github/actions/setup_test_project/setup_test_project.mjs Outdated Show resolved Hide resolved

Tobbe reviewed May 29, 2023

View reviewed changes

packages/vite/bins/rw-vite-dev.mjs Outdated Show resolved Hide resolved

Tobbe approved these changes May 29, 2023

View reviewed changes

PR suggestions

58cb10a

dac09 enabled auto-merge (squash) May 30, 2023 05:25

dac09 merged commit 6585d4d into redwoodjs:main May 30, 2023

redwoodjs-bot bot added this to the next-release milestone May 30, 2023

dac09 deleted the feat/make-vite-default branch May 31, 2023 03:02

jtoar modified the milestones: next-release, v6.0.0 Jun 1, 2023

jtoar mentioned this pull request Jun 10, 2023

[Bug?]: project:sync is broken #8580

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Vite the default bundler #8301

Make Vite the default bundler #8301

dac09 commented May 12, 2023 •

edited

Loading

replay-io bot commented May 12, 2023 •

edited

Loading

dac09 May 17, 2023

dac09 May 17, 2023 •

edited

Loading

dac09 commented May 29, 2023

Tobbe May 29, 2023

Make Vite the default bundler #8301

Make Vite the default bundler #8301

Conversation

dac09 commented May 12, 2023 • edited Loading

replay-io bot commented May 12, 2023 • edited Loading

dac09 May 17, 2023

Choose a reason for hiding this comment

dac09 May 17, 2023 • edited Loading

Choose a reason for hiding this comment

dac09 commented May 29, 2023

Tobbe May 29, 2023

Choose a reason for hiding this comment

dac09 commented May 12, 2023 •

edited

Loading

replay-io bot commented May 12, 2023 •

edited

Loading

dac09 May 17, 2023 •

edited

Loading