-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql-server): Display correct plugin name in error message #8271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
19 replays were recorded for 6304338.
|
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 12, 2023
* 'main' of github.com:redwoodjs/redwood: fix(deps): update dependency @heroicons/react to v2.0.18 (redwoodjs#8277) chore(release): publish in two steps for lock file chore(deps): update dependency glob to v10.2.3 (redwoodjs#8275) chore(deps): update dependency nx to v16.1.4 (redwoodjs#8276) Fix --rebuildFixture (redwoodjs#8273) chore(release): update command for crwa templates chore(crwa test, release process): handle yarn.lock chore(Nx): change @nrwl/nx-cloud to nx-cloud (redwoodjs#8272) fix(graphql-server): Display correct plugin name in error message (redwoodjs#8271) chore(cli): Consistent use of util functions within experimental commands (redwoodjs#8268) Draw only at start and end when dealing with non-tty (redwoodjs#8265) fix(deps): update prisma monorepo to v4.14.0 (redwoodjs#8269) fix(deps): update dependency webpack-cli to v5.1.1 (redwoodjs#8266)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8270
I had failed to update the error message when copying over the envelop plugin. This corrects that oversight.
Comment: I'll likely produce a PR to update the envelop plugin once we've fully integrated and tested this custom/updated version in Redwood.