Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-server): Display correct plugin name in error message #8271

Merged
merged 3 commits into from
May 9, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Fixes #8270

I had failed to update the error message when copying over the envelop plugin. This corrects that oversight.

Comment: I'll likely produce a PR to update the envelop plugin once we've fully integrated and tested this custom/updated version in Redwood.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label May 9, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from dthyresson May 9, 2023 15:43
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthyresson dthyresson enabled auto-merge (squash) May 9, 2023 15:50
@replay-io
Copy link

replay-io bot commented May 9, 2023

19 replays were recorded for 6304338.

image 0 Failed
image 19 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/a976d37e-9be5-483f-a14f-ab1b9888e774>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/a1655b87-7253-4bea-9346-21a69ef2c1bb>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/0e2b89a4-2824-4196-9e40-a8caf4c7cbfc>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/a2056094-e64f-40e9-8da6-4df6d3e90418>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/99d303a9-02b3-4297-8c72-401da19fdbed>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/5c9891bf-d778-4378-a64c-09ba05d671be>Check that rehydration works for page not wrapped in Set</a></li>
      <li><a href=https://app.replay.io/recording/d7b1e229-f34f-48da-be8c-06921fdbbd96>Check that rehydration works for page with Cell in Set</a></li>
      <li><a href=https://app.replay.io/recording/f69eae55-ed1a-4c8d-ae70-8830349c29b4>Check that rehydration works for page with code split chunks</a></li>
      <li><a href=https://app.replay.io/recording/1fe251c3-4946-431e-acab-e1794e2542e2>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/87c0968c-92d7-440a-a59d-f9ccb67d1af2>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/5b826888-129b-4afb-92fc-d3cb387e489d>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/89b617fe-dd21-4c2c-aa7e-869ae81c20b9>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/0b80ecca-0980-4813-bcb0-f36e6a1a6e53>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/4c6c9f52-8784-4f9c-8aee-e7d331f09de6>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/ad4c758f-af47-4dd5-868e-79c2345e853e>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/7920c93e-3d28-4230-a2a6-f512e58e2dec>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/d6f6d9f1-3ccf-4634-9537-f51a6d964312>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/c2745211-b33b-4ebf-a017-4630a05978c1>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@jtoar jtoar disabled auto-merge May 9, 2023 16:36
@jtoar jtoar merged commit 7a64cbd into main May 9, 2023
@jtoar jtoar deleted the jgmw-graphql/otel-error-message branch May 9, 2023 16:37
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 9, 2023
jtoar pushed a commit that referenced this pull request May 9, 2023
@jtoar jtoar modified the milestones: next-release, v5.1.0 May 9, 2023
dac09 added a commit to dac09/redwood that referenced this pull request May 12, 2023
* 'main' of github.com:redwoodjs/redwood:
  fix(deps): update dependency @heroicons/react to v2.0.18 (redwoodjs#8277)
  chore(release): publish in two steps for lock file
  chore(deps): update dependency glob to v10.2.3 (redwoodjs#8275)
  chore(deps): update dependency nx to v16.1.4 (redwoodjs#8276)
  Fix --rebuildFixture (redwoodjs#8273)
  chore(release): update command for crwa templates
  chore(crwa test, release process): handle yarn.lock
  chore(Nx): change @nrwl/nx-cloud to nx-cloud (redwoodjs#8272)
  fix(graphql-server): Display correct plugin name in error message (redwoodjs#8271)
  chore(cli): Consistent use of util functions within experimental commands (redwoodjs#8268)
  Draw only at start and end when dealing with non-tty (redwoodjs#8265)
  fix(deps): update prisma monorepo to v4.14.0 (redwoodjs#8269)
  fix(deps): update dependency webpack-cli to v5.1.1 (redwoodjs#8266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: useRedwoodOpenTelemetry GraphQL plugin refers incorrectly to new relic
3 participants