Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: useRedwoodOpenTelemetry GraphQL plugin refers incorrectly to new relic #8270

Closed
1 task
dthyresson opened this issue May 9, 2023 · 1 comment · Fixed by #8271
Closed
1 task
Assignees
Labels
bug/needs-info More information is needed for reproduction

Comments

@dthyresson
Copy link
Contributor

What's not working?

See graphql-server/src/plugins/useRedwoodOpenTelemetry.ts

The error warning message refers to newrelic, but this is the open telemetry plugin.

      const resultCbs: OnExecuteHookResult<PluginContext> = {
        onExecuteDone({ result }) {
          if (isAsyncIterable(result)) {
            executionSpan.end()
            // eslint-disable-next-line no-console
            console.warn(
👉              `Plugin "newrelic" encountered a AsyncIterator which is not supported yet, so tracing data is not available for the operation.`
            )
            return
          }

How do we reproduce the bug?

Reproduced by running Redwood test project in local prod via yarn rw serve and testing live queries:

Web server started on http://localhost:8910
API serving from http://localhost:8910
API listening on http://localhost:8910/.redwood/functions/
GraphQL endpoint at /.redwood/functions/graphql
Plugin "newrelic" encountered a AsyncIterator which is not supported yet, so tracing data is not available for the operation.
Plugin "newrelic" encountered a AsyncIterator which is not supported yet, so tracing data is not available for the operation.
Plugin "newrelic" encountered a AsyncIterator which is not supported yet, so tracing data is not available for the operation.

What's your environment? (If it applies)

OSX

Are you interested in working on this?

  • I'm interested in working on this
@dthyresson dthyresson added the bug/needs-info More information is needed for reproduction label May 9, 2023
@Josh-Walker-GM
Copy link
Collaborator

This appears to have been pulled in from the 'upstream' evelop plugin which I used as the base implementation before performing some updates.

https://github.com/n1ru4l/envelop/blob/2fa8c2f78ca160dc69cfa0735f019efc1968b042/packages/plugins/opentelemetry/src/index.ts#L114

Is it just the error message that you're wishing to highlight or is it the support for AsyncIterator too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/needs-info More information is needed for reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants