fix(cli): Handle importing optional setup auth commands #6997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-make-some-auth-providers-optional
branch
from
6d17cd0 to
c39e3e4
Compare
jtoar
changed the title
Tobbe
approved these changes
Nov 30, 2022
jtoar
force-pushed
the
ds-make-some-auth-providers-optional
branch
from
7324d87 to
77c27f3
Compare
jtoar
commented
Nov 30, 2022
| @@ -5,9 +5,10 @@ import { | |||
| standardAuthHandler, | |||
| } from '@redwoodjs/cli-helpers' | |||
|
|
|||
| export const command = 'azureActiveDirectory' | |||
| export const command = 'azure-active-directory' | |||
There was a problem hiding this comment.
I was getting this yargs error when it was camel cased:
YError: Invalid first argument. Expected string or array or object but received undefined.
at c (/Users/dom/prjcts/redwood/redwood-app-2/node_modules/yargs/build/index.cjs:1:2269)
at /Users/dom/prjcts/redwood/redwood-app-2/node_modules/yargs/build/index.cjs:1:1986
at Array.forEach (<anonymous>)
at h (/Users/dom/prjcts/redwood/redwood-app-2/node_modules/yargs/build/index.cjs:1:1906)
at Xt.command (/Users/dom/prjcts/redwood/redwood-app-2/node_modules/yargs/build/index.cjs:1:32560)
at addSetupCommand (/Users/dom/prjcts/redwood/redwood-app-2/node_modules/@redwoodjs/cli/dist/commands/setup/auth/auth.js:61:24)
at async builder (/Users/dom/prjcts/redwood/redwood-app-2/node_modules/@redwoodjs/cli/dist/commands/setup/auth/auth.js:65:5)
dac09
added a commit
that referenced
this pull request
Dec 6, 2022
…xperimental-vite-optin * 'main' of github.com:redwoodjs/redwood: (26 commits) Compress v1 (1.0-1.5) docs to v1.x (#7025) Ch4: Deployment - Updating Environment variable section (#6970) fix(deps): update dependency systeminformation to v5.16.0 (#7011) fix(deps): update graphqlcodegenerator monorepo (#7005) fix(deps): update dependency concurrently to v7.6.0 (#7006) fix(deps): update dependency mini-css-extract-plugin to v2.7.1 (#7007) fix(deps): update dependency eslint to v8.28.0 (#7008) fix(deps): update dependency prettier to v2.8.0 (#7009) fix(deps): update dependency react-hook-form to v7.40.0 (#7010) chore(deps): update dependency lerna to v6.1.0 (#6993) fix(deps): update dependency @fastify/http-proxy to v8.4.0 (#6995) fix(deps): update prisma monorepo to v4.7.0 (#6999) fix(deps): update dependency jest-watch-typeahead to v2.2.1 (#6991) fix(deps): update dependency listr2 to v5.0.6 (#6989) chore(deps): update dependency cypress to v11.2.0 (#6992) chore(deps): update dependency nx to v15.2.4 (#6994) fix(deps): update dependency msw to v0.49.1 (#6996) auth-firebase-* (#6987) fix(cli): Handle importing optional setup auth commands (#6997) fix(deps): update dependency eslint-plugin-react to v7.31.11 (#6990) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're starting to move the auth providers out of the
auth-provider-*packages. See...This PR adds basic import handling to the setup auth command so that it doesn't break when the auth setup commands are fully removed as CLI dependencies. This could be a preliminary version of plugins where the set of plugins available is hardcoded. But this is mostly just to keep things from breaking for now.