Ch4: Deployment - Updating Environment variable section #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify has changed how Environment Variables are set. They are no longer nested inside Build & Deploy.
There was a problem hiding this comment.
Thanks for the update, @MrOnosa! I have reviewed the Env vars section, and all seems well there with Netlify's new Env. Var section. I have not confirmed the change with "Site is live" to "Deployment failed". If noone gets to it prior, I will look to get that confirmed this week. Thanks again!
|
Thank you for double-checking everything. Always appreciated. For context, this is what it shows for me. |
|
Thanks so much for this PR! |
|
You can preview the changes here: https://deploy-preview-6970--redwoodjs-docs.netlify.app/docs/canary/tutorial/chapter4/deployment#environment-variables |
cannikin
approved these changes
Dec 2, 2022
|
Looks great, thanks for the fix! |
dac09
added a commit
that referenced
this pull request
Dec 6, 2022
…xperimental-vite-optin * 'main' of github.com:redwoodjs/redwood: (26 commits) Compress v1 (1.0-1.5) docs to v1.x (#7025) Ch4: Deployment - Updating Environment variable section (#6970) fix(deps): update dependency systeminformation to v5.16.0 (#7011) fix(deps): update graphqlcodegenerator monorepo (#7005) fix(deps): update dependency concurrently to v7.6.0 (#7006) fix(deps): update dependency mini-css-extract-plugin to v2.7.1 (#7007) fix(deps): update dependency eslint to v8.28.0 (#7008) fix(deps): update dependency prettier to v2.8.0 (#7009) fix(deps): update dependency react-hook-form to v7.40.0 (#7010) chore(deps): update dependency lerna to v6.1.0 (#6993) fix(deps): update dependency @fastify/http-proxy to v8.4.0 (#6995) fix(deps): update prisma monorepo to v4.7.0 (#6999) fix(deps): update dependency jest-watch-typeahead to v2.2.1 (#6991) fix(deps): update dependency listr2 to v5.0.6 (#6989) chore(deps): update dependency cypress to v11.2.0 (#6992) chore(deps): update dependency nx to v15.2.4 (#6994) fix(deps): update dependency msw to v0.49.1 (#6996) auth-firebase-* (#6987) fix(cli): Handle importing optional setup auth commands (#6997) fix(deps): update dependency eslint-plugin-react to v7.31.11 (#6990) ...
jtoar
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Ch4 - Updating Environment variable section Netlify has changed how Environment Variables are set. They are no longer nested inside Build & Deploy. * Ch4- Deployment Updating image to show new netlify UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify has changed how Environment Variables are set. They are no longer nested inside Build & Deploy.