(chore): Fix rebuild fixture #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 62c56bc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
playwright has many kinds of timeouts. I've seen this test fail on both "timeouts" and "expect timeouts". we've increased timeouts in the past, but never expect timeouts, so let's try increasing those (from 5 seconds to 10 seconds). I also increased the regular timeouts for linux + macOs cause I've seen it fail at 60s too
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jul 25, 2022
…ctmode-gen * 'main' of github.com:redwoodjs/redwood: (chore): Fix rebuild fixture (redwoodjs#6033)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild fixture will now copy over framework dependencies (just like
--link) when generating a test project.At the end just before replacing the test-project in
__fixtures/test-projectit'll copy over the package.json from the crwa template, to make sure we don't have the linked devDeps in the fixture.