Rebuild fixtures to make build:test-project work properly #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
|
Thanks @KrisCoulson! This looks good, but we should probably merge #5491 first since it also updates the test project. (In this case, you'll probably be the one having to deal with merge conflicts—sorry!) |
|
Thanks @KrisCoulson, we rebuilt the fixture for the TS PR (#6033) so I'll close this one out. I'll be better about doing it when it's necessary going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was receiving multiple errors when trying to run
yarn build:test-projectafter rebuilding the fixtures the errors were no longer happening. @thedavidprice asked me to open a PR with the fixtures updated.The code below doesn't seem like it updated too much except tailwind to 3.1.4 and reordered a bunch of imports. But it did allow my test project to actually be built correctly.