-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade webpack v5 and related modules #2402
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ FailuresThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
FYI: Storybook v6.3 will include stable support for Webpack v5 |
@peterp I attempted further diagnoses. I believe it's a Webpack config error. I attempted disabling loaders and plugins and ... to no avail — I never could resolve the error or produce a different one. My 🧠 is 🍳 |
this has moved to #2884 Keeping this open for reference in time being |
I know, I know... Webpack v5 takes longer to build. I'd argue it's time to upgrade as other packages are deprecating v4. And this will give us impetus to push forward with ESbuild.
https://webpack.js.org/migrate/5/
To Do:
yarn rw dev
start errorStarting the Webpack Dev Server includes the following error (last line starting with
web | [HPM] Error
). However, this does not seem to actually affect the Dev Server running and the error is not repeated:Possible improvement:
-[ ] "If you have rules defined for loading assets using raw-loader, url-loader, or file-loader, please use Asset Modules instead as they're going to be deprecated in near future.": https://webpack.js.org/guides/asset-modules/