Update react-hook-form to 7.6.1 #2270

lunchbreakdev · 2021-04-13T15:13:24Z

Started updating react-hook-form to 7.0.7 to close #2253

Disclaimer: first contribution besides minor typo fixes 😂

I believe all necessary files are updated but I'm running into a configuration error with the tests. It appears to be occurring in the jest.config.js file, but I may have done something wrong.

Happy to make any other edits if I missed anything!

github-actions · 2021-04-13T15:16:45Z

📦 PR Packages

Click to Show Package Download Links

Install this PR by running yarn rw upgrade --pr 2270:0.31.2-0170be3

thedavidprice · 2021-04-13T15:22:08Z

This is awesome @morganmspencer 🚀 Looping in @cannikin for review + direction.

sriverag · 2021-04-30T03:22:48Z

@morganmspencer - This looks awesome! I suggest including the yarn.lock file because the Cypress E2E tests check is installing the dependencies using yarn install --frozen-lockfile probably causing the tests to fail.

thedavidprice · 2021-05-01T00:50:55Z

@morganmspencer could you update to the most recent React Hook Form version?
https://github.com/react-hook-form/react-hook-form/releases

pinging @cannikin for review

thedavidprice · 2021-05-11T22:45:20Z

@morganmspencer I took a stab at getting this one into upcoming Redwood v0.32 — couldn't quite get it there:

bumped React-Hook-Form to 7.5.2
updated packages/forms/jest.config.js
combed through the RHF Changelog as they'd renamed a lot of the Types (without mentioning in Migration guide 🤦‍♂️)

CHANGELOG.md

Migration Guide

Status

The tests are now running although I'm seeing a strange error at the beginning regarding:

...
Error: Uncaught [TypeError: Cannot read property 'focus' of null]
...
  The above error occurred in the <TestComponentWithRef> component:
    at TestComponentWithRef (/Users/price/Repos/redwoodjs-redwood/packages/forms/src/__tests__/form.test.tsx:102:27)

Hopefully this is enough to get you going again?

thedavidprice · 2021-05-11T22:47:01Z

packages/forms/src/index.tsx

@@ -268,7 +273,7 @@ const TextAreaField = forwardRef<
    <textarea
      {...tagProps}
      id={props.id || props.name}
-      ref={(element) => {
+      {...(element: HTMLTextAreaElement | any) => {


Using any was the only type that didn't give an error. I'm no TS expert so assuming there's a better way to handle this.

Note: multiple occurrences below as well.

…ecifying attributes returned from register function

lunchbreakdev · 2021-05-18T16:31:33Z

@thedavidprice it looks like the register function with the spread operator is returning the ref attribute (as well as onChange, onBlur and name). I think this may have been causing the error with ref, so I used the register call separately and defined the onChange and onBlur attributes explicitly.

I could be way off base with this way but 6 out of 12 tests now pass as opposed to the 3 from before. 🤷‍♂️

Would love any help with fixing the other tests.

cannikin · 2021-05-27T17:50:33Z

upgrading to v7 is critical path at this point

thedavidprice · 2021-05-27T17:55:19Z

Feeling the pain 😭 --> #2402

cannikin · 2021-05-27T18:55:45Z

Might be time to relax that "latest major version" requirement!

jtoar · 2021-05-28T00:52:17Z

@cannikin while we're talking about it, what do you think of this one? #1434. If we think it's a good idea, we should probably do it all at the same time.

Update: just rediscovered the discussion here, seemed like we were all on board: #1431 (comment)

jtoar · 2021-05-28T01:33:30Z

Note to self: these enums need to be changed (see the discussion here #2641 (comment)):

redwood/packages/forms/src/index.tsx

Lines 30 to 52 in e6c941a

    
           enum INPUT_TYPES { 
        
             BUTTON = 'button', 
        
             COLOR = 'color', 
        
             DATE = 'date', 
        
             DATETIME_LOCAL = 'datetime-local', 
        
             EMAIL = 'email', 
        
             FILE = 'file', 
        
             HIDDEN = 'hidden', 
        
             IMAGE = 'image', 
        
             MONTH = 'month', 
        
             NUMBER = 'number', 
        
             PASSWORD = 'password', 
        
             RADIO = 'radio', 
        
             RANGE = 'range', 
        
             RESET = 'reset', 
        
             SEARCH = 'search', 
        
             SUBMIT = 'submit', 
        
             TEL = 'tel', 
        
             TEXT = 'text', 
        
             TIME = 'time', 
        
             URL = 'url', 
        
             WEEK = 'week', 
        
           }

lunchbreakdev · 2021-05-28T12:23:00Z

Note to self: these enums need to be changed (see the discussion here #2641 (comment)):

redwood/packages/forms/src/index.tsx

Lines 30 to 52 in e6c941a

enum INPUT_TYPES {

BUTTON = 'button',

COLOR = 'color',

DATE = 'date',

DATETIME_LOCAL = 'datetime-local',

EMAIL = 'email',

FILE = 'file',

HIDDEN = 'hidden',

IMAGE = 'image',

MONTH = 'month',

NUMBER = 'number',

PASSWORD = 'password',

RADIO = 'radio',

RANGE = 'range',

RESET = 'reset',

SEARCH = 'search',

SUBMIT = 'submit',

TEL = 'tel',

TEXT = 'text',

TIME = 'time',

URL = 'url',

WEEK = 'week',

}

I just added a change for this

jtoar · 2021-05-28T17:32:30Z

@morganmspencer awesome thanks!

thedavidprice · 2021-06-09T06:07:55Z

@morganmspencer thanks for your willingness and patience with this PR! Assuming we can get someone to help guide you through the next steps, are you still available and interested in continuing with this?

thedavidprice · 2021-06-09T06:08:35Z

General Note:
I suggest this PR also include the option 2 recommendation from this issue "Deprecate validation in <Form>" #1434

lunchbreakdev · 2021-06-09T10:42:20Z

@thedavidprice I'm definitely still interested in working on this one with a bit of guidance

thedavidprice · 2021-06-11T23:54:10Z

@morganmspencer thanks! I've asked @dthyresson to take a look and check back here. Keep a 👀!

thedavidprice · 2021-07-21T23:05:59Z

Hi @morganmspencer We are going to close this PR and pick up the work in #3043

Appreciate all your help (and patience) and welcome you to join in on the new PR if you'd like. No pressure! Just know your help is always welcome.

Update react-hook-form package

be962bd

thedavidprice requested a review from cannikin April 13, 2021 15:21

Merge branch 'main' into main

73ee668

thedavidprice mentioned this pull request May 1, 2021

Build(deps): Bump react-hook-form from 6.15.4 to 7.3.6 #2424

Closed

lunchbreakdev added 2 commits April 30, 2021 20:52

Merge branch 'main' into main

a986b7a

Update react-hook-form to 7.3.6

d656d4a

lunchbreakdev changed the title ~~Update react-hook-form to 7.0.7~~ Update react-hook-form to 7.3.6 May 1, 2021

thedavidprice added 4 commits May 11, 2021 14:33

Merge branch 'main' into pr/2270

5e03765

update yarn.lock

2867912

update yarn.lock

b665eaf

misc updates to get test running

03e4f05

thedavidprice changed the title ~~Update react-hook-form to 7.3.6~~ Update react-hook-form to 7.5.2 May 11, 2021

Merge branch 'main' into main

0170be3

thedavidprice reviewed May 11, 2021

View reviewed changes

thedavidprice added the release:breaking This PR is a breaking change label May 11, 2021

thedavidprice mentioned this pull request May 11, 2021

build(deps): bump react-hook-form from 6.15.4 to 7.5.2 #2478

Closed

Merge branch 'main' into main

fce10ed

thedavidprice mentioned this pull request May 14, 2021

build(deps): bump react-hook-form from 6.15.4 to 7.5.3 #2523

Closed

jtoar added this to the v1.0 milestone May 18, 2021

lunchbreakdev added 2 commits May 18, 2021 10:03

Merge branch 'main' into main

6eec246

Update forms index to allow for the ref to be passed by explicitly sp…

8d08a57

…ecifying attributes returned from register function

Bump react-hook-form to 7.6.1

feb8004

lunchbreakdev changed the title ~~Update react-hook-form to 7.5.2~~ Update react-hook-form to 7.6.1 May 18, 2021

jtoar assigned lunchbreakdev and jtoar May 28, 2021

Update enums to types

eb2bc3d

lunchbreakdev added 2 commits May 28, 2021 08:36

Update loop over inputTypes

4d33e52

Merge branch 'main' into main

58ca114

This was referenced Jun 8, 2021

Upgrading redwood from v0.32.2 to v0.33.2 causes react-hook-form error. #2763

Closed

Deprecate validation in <Form> #1434

Closed

thedavidprice mentioned this pull request Jul 7, 2021

FieldError cannot retrieves error message from chained path #2979

Closed

LBrian mentioned this pull request Jul 15, 2021

Upgrade RHF to v7.11.0 #3043

Merged

jtoar assigned lunchbreakdev and jtoar and unassigned cannikin, lunchbreakdev and jtoar Jul 19, 2021

thedavidprice closed this Jul 21, 2021

redwoodjs-bot bot removed this from the next-release-priority milestone Jul 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update react-hook-form to 7.6.1 #2270

Update react-hook-form to 7.6.1 #2270

lunchbreakdev commented Apr 13, 2021

github-actions bot commented Apr 13, 2021 •

edited

Loading

thedavidprice commented Apr 13, 2021

sriverag commented Apr 30, 2021

thedavidprice commented May 1, 2021

thedavidprice commented May 11, 2021

thedavidprice May 11, 2021

lunchbreakdev commented May 18, 2021

cannikin commented May 27, 2021

thedavidprice commented May 27, 2021

cannikin commented May 27, 2021

jtoar commented May 28, 2021 •

edited

Loading

jtoar commented May 28, 2021

lunchbreakdev commented May 28, 2021

jtoar commented May 28, 2021

thedavidprice commented Jun 9, 2021

thedavidprice commented Jun 9, 2021 •

edited

Loading

lunchbreakdev commented Jun 9, 2021

thedavidprice commented Jun 11, 2021

thedavidprice commented Jul 21, 2021

Update react-hook-form to 7.6.1 #2270

Update react-hook-form to 7.6.1 #2270

Conversation

lunchbreakdev commented Apr 13, 2021

github-actions bot commented Apr 13, 2021 • edited Loading

📦 PR Packages

thedavidprice commented Apr 13, 2021

sriverag commented Apr 30, 2021

thedavidprice commented May 1, 2021

thedavidprice commented May 11, 2021

Status

thedavidprice May 11, 2021

Choose a reason for hiding this comment

lunchbreakdev commented May 18, 2021

cannikin commented May 27, 2021

thedavidprice commented May 27, 2021

cannikin commented May 27, 2021

jtoar commented May 28, 2021 • edited Loading

jtoar commented May 28, 2021

lunchbreakdev commented May 28, 2021

jtoar commented May 28, 2021

thedavidprice commented Jun 9, 2021

thedavidprice commented Jun 9, 2021 • edited Loading

lunchbreakdev commented Jun 9, 2021

thedavidprice commented Jun 11, 2021

thedavidprice commented Jul 21, 2021

github-actions bot commented Apr 13, 2021 •

edited

Loading

jtoar commented May 28, 2021 •

edited

Loading

thedavidprice commented Jun 9, 2021 •

edited

Loading