Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2190153) pstore: fix crash and forward dummy arguments instead of NULL #385

Merged
merged 3 commits into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/advanced-commit-linter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
policy:
cherry-pick:
upstream:
- github: systemd/systemd
- github: systemd/systemd-stable
exception:
note:
- rhel-only
jamacku marked this conversation as resolved.
Show resolved Hide resolved
tracker:
- keyword:
- 'Resolves: #?'
- 'Related: #?'
- 'Reverts: #?'
issue-format:
- '\d+$'
url: 'https://bugzilla.redhat.com/show_bug.cgi?id='
- keyword:
- 'Resolves: '
- 'Related: '
- 'Reverts: '
issue-format:
- 'RHEL-\d+$'
url: 'https://issues.redhat.com/browse/'
28 changes: 28 additions & 0 deletions .github/workflows/gather-metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Gather Pull Request Metadata
on:
pull_request:
types: [ opened, reopened, synchronize ]
branches:
- main
- rhel-8.*.0

permissions:
contents: read

jobs:
gather-metadata:
runs-on: ubuntu-latest

steps:
- name: Repository checkout
uses: actions/checkout@v3

- id: Metadata
name: Gather Pull Request Metadata
uses: redhat-plumbers-in-action/gather-pull-request-metadata@v1

- name: Upload artifact with gathered metadata
uses: actions/upload-artifact@v3
with:
name: pr-metadata
path: ${{ steps.Metadata.outputs.metadata-file }}
45 changes: 45 additions & 0 deletions .github/workflows/source-git-automation.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Source git Automation
on:
workflow_run:
workflows: [ Gather Pull Request Metadata ]
types:
- completed

permissions:
contents: read

jobs:
download-metadata:
if: >
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.conclusion == 'success'
runs-on: ubuntu-latest

outputs:
pr-metadata: ${{ steps.Artifact.outputs.pr-metadata-json }}

steps:
- id: Artifact
name: Download Artifact
uses: redhat-plumbers-in-action/download-artifact@v1
with:
name: pr-metadata

commit-linter:
needs: [ download-metadata ]
runs-on: ubuntu-latest

outputs:
validated-pr-metadata: ${{ steps.commit-linter.outputs.validated-pr-metadata }}

permissions:
statuses: write
pull-requests: write

steps:
- id: commit-linter
name: Lint Commits
uses: redhat-plumbers-in-action/advanced-commit-linter@v1
with:
pr-metadata: ${{ needs.download-metadata.outputs.pr-metadata }}
token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion src/pstore/pstore.c
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ static int run(int argc, char *argv[]) {

/* Move left over files out of pstore */
for (size_t n = 0; n < list.n_entries; n++)
(void) move_file(&list.entries[n], NULL, NULL);
(void) move_file(&list.entries[n], "/", "/");

return 0;
}
Expand Down