(#2190153) pstore: fix crash and forward dummy arguments instead of NULL #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracker - 2190153 The following commits meet all requirements
|
|
@jamacku Apparently bot has eaten the bug reference in the description. |
jamacku
reviewed
Apr 27, 2023
[msekleta: in our version of systemd "const char path*" argument of path_join() can't be NULL. Here we don't really want any subdirs paths passed into move_file(), but we can't just pass NULL pointers because they will be forwarded to path_join(). Hence, let's just pass "/" instead.] rhel-only Related: #2190153
Workflow gathers metadata like pull request numbers and information about commits. This metadata is used for commit validation and other actions. This workflow also triggers for rest of the source-git automation workflows. rhel-only Related: #2190153
Add a GitHub Workflow that is triggered on `workflow_run` events. It uses metadata provided by `redhat-plumbers-in-action/gather-pull-request-metadata` GitHub Action to get the PR number and the commit metadata. The commit metadata is then used to check if the commit message contains all required information (tracker and upstream reference). GitHub Action responsible for commit verification `redhat-plumbers-in-action/advanced-commit-linter` is configured via the `advanced-commit-linter.yml` file. rhel-only Related: #2190153
msekletar
force-pushed
the
pstore-crash-8-8
branch
from
daf536b to
3a8bf07
Compare
Sorry, |
jamacku
added a commit
to jamacku/advanced-commit-linter
that referenced
this pull request
Apr 27, 2023
issue-metadata PR: - redhat-plumbers-in-action/issue-metadata#18 Resolves issue encountered in: - redhat-plumbers/systemd-rhel8#385
jamacku
added a commit
to redhat-plumbers-in-action/advanced-commit-linter
that referenced
this pull request
Apr 27, 2023
issue-metadata PR: - redhat-plumbers-in-action/issue-metadata#18 Resolves issue encountered in: - redhat-plumbers/systemd-rhel8#385
systemd-rhel-bot
changed the title
jamacku
changed the title
systemd-rhel-bot
added
tracker/unapproved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2190153