-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Added sleep and timeout for while loop (#2029) #2037
Chore: Added sleep and timeout for while loop (#2029) #2037
Conversation
…2029) * Added sleep and timeout for while loop * Added If else structure for Gettting Resource Attribute Kw for when value comes empty
Quality Gate passedIssues Measures |
@@ -282,5 +282,9 @@ | |||
${rc} ${value}= Run And Return Rc And Output | |||
... oc get ${resource_type}/${resource_name} -n ${namespace} -o 'jsonpath={${attribute_path}}' | |||
Should Be Equal "${rc}" "0" msg=${value} | |||
Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | |||
IF "${value}" != "${EMPTY}" | |||
Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | ||
IF "${value}" != "${EMPTY}" | ||
Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | ||
ELSE |
Check warning
Code scanning / Robocop
Trailing whitespace at the end of line Warning test
IF "${value}" != "${EMPTY}" | ||
Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | ||
ELSE | ||
Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is EMPTY |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
@@ -10,6 +10,7 @@ | |||
${SUBSCRIPTION_YAML_TEMPLATE_FILEPATH}= ${FILES_RESOURCES_DIRPATH}/isv-operator-subscription.yaml | |||
${OPERATORGROUP_YAML_TEMPLATE_FILEPATH}= ${FILES_RESOURCES_DIRPATH}/isv-operator-group.yaml | |||
${IS_PRESENT}= 0 | |||
${installplan_name} ${EMPTY} |
Check warning
Code scanning / Robocop
Section variable '{{ variable_name }}' name should be uppercase Warning test
@@ -10,6 +10,7 @@ | |||
${SUBSCRIPTION_YAML_TEMPLATE_FILEPATH}= ${FILES_RESOURCES_DIRPATH}/isv-operator-subscription.yaml | |||
${OPERATORGROUP_YAML_TEMPLATE_FILEPATH}= ${FILES_RESOURCES_DIRPATH}/isv-operator-group.yaml | |||
${IS_PRESENT}= 0 | |||
${installplan_name} ${EMPTY} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent inside the variables section. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added sleep and timeout for while loop
Added If else structure for Gettting Resource Attribute Kw for when value comes empty