Chore: Added sleep and timeout for while loop #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asanzgom
added
the
enhancements
asanzgom
requested review from
jgarciao,
MarianMacik,
mattmahoneyrh,
CFSNM and
bdattoma
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -311,7 +311,11 @@ | |||
| ${rc} ${value}= Run And Return Rc And Output | |||
| ... oc get ${resource_type}/${resource_name} -n ${namespace} -o 'jsonpath={${attribute_path}}' | |||
| Should Be Equal "${rc}" "0" msg=${value} | |||
| Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | |||
| IF "${value}" != "${EMPTY}" | |||
| Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | ||
| IF "${value}" != "${EMPTY}" | ||
| Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | ||
| ELSE |
Check warning
Code scanning / Robocop
Trailing whitespace at the end of line Warning test
| IF "${value}" != "${EMPTY}" | ||
| Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is ${value} | ||
| ELSE | ||
| Log To Console ${resource_type} ${resource_name} in the namespace ${namespace} attribute ${attribute_path} value is EMPTY |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
lugi0
approved these changes
Nov 14, 2024
asanzgom
deleted the
hotfix/Install_ISV_Operator_From_OperatorHub_Via_CLI
branch
CFSNM
pushed a commit
to CFSNM/ods-ci
that referenced
this pull request
Nov 15, 2024
…2029) * Added sleep and timeout for while loop * Added If else structure for Gettting Resource Attribute Kw for when value comes empty
CFSNM
pushed a commit
to CFSNM/ods-ci
that referenced
this pull request
Nov 15, 2024
…2029) * Added sleep and timeout for while loop * Added If else structure for Gettting Resource Attribute Kw for when value comes empty
CFSNM
added a commit
that referenced
this pull request
Nov 18, 2024
CFSNM
added a commit
that referenced
this pull request
Nov 18, 2024
lenahorsley
pushed a commit
to lenahorsley/ods-ci
that referenced
this pull request
Nov 18, 2024
…2029) * Added sleep and timeout for while loop * Added If else structure for Gettting Resource Attribute Kw for when value comes empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.