Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-14416 - Implement check for missing tests #1951

Merged
merged 1 commit into from
Oct 24, 2024
Merged

RHOAIENG-14416 - Implement check for missing tests #1951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@
... env:CODEFLARE_TEST_OUTPUT_DIR=%{WORKSPACE}/codeflare-${test_binary}-logs
... env:FMS_HF_TUNING_IMAGE=${FMS_HF_TUNING_IMAGE}
Log To Console ${result.stdout}
Check missing Go test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
IF ${result.rc} != 0
FAIL ${TEST_NAME} failed
END
Expand Down Expand Up @@ -212,6 +213,12 @@
... env:PIP_INDEX_URL=${PIP_INDEX_URL}
... env:PIP_TRUSTED_HOST=${PIP_TRUSTED_HOST}
Log To Console ${result.stdout}
Check missing Go test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
ChughShilpa marked this conversation as resolved.
Show resolved Hide resolved
IF ${result.rc} != 0
FAIL ${TEST_NAME} failed
END

Check missing Go test

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
[Documentation] Check that upstream Go test is not missing
[Arguments] ${test_run_output}
Should Not Contain ${test_run_output} testing: warning: no tests to run No Go tests were run
7 changes: 7 additions & 0 deletions .../0600__distributed_workloads/0601__workloads_orchestration/test-run-kueue-e2e-tests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
... env:NAMESPACE=${APPLICATIONS_NAMESPACE}
... env:SKIP_JOB_SET_AVAILABILITY_CHECK=true
Log To Console ${result.stdout}
Check missing test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing test' does not follow case convention
IF ${result.rc} != 0
FAIL failed
END
Expand All @@ -95,6 +96,12 @@
... env:NAMESPACE=${APPLICATIONS_NAMESPACE}
... env:SKIP_JOB_SET_AVAILABILITY_CHECK=true
Log To Console ${result.stdout}
Check missing test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing test' does not follow case convention
IF ${result.rc} != 0
FAIL failed
END

Check missing test

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing test' does not follow case convention
[Documentation] Check that upstream test is not missing
[Arguments] ${test_run_output}
Should Not Match Regexp ${test_run_output} .*Ran 0 of .* Specs.* No tests were run
2 changes: 2 additions & 0 deletions ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-run-kuberay-e2e.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
Library OperatingSystem
Library Process
Resource ../../../../tasks/Resources/RHODS_OLM/install/oc_install.robot
Resource ../../../Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

*** Variables ***
${KUBERAY_RELEASE_ASSETS} %{KUBERAY_RELEASE_ASSETS=https://github.com/opendatahub-io/kuberay/releases/latest/download}
Expand Down Expand Up @@ -85,6 +86,7 @@
... timeout=20m
... stdout=${TEMPDIR}/output.txt
Log To Console ${result.stdout}
Check missing Go test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
IF ${result.rc} != 0
FAIL ${test_name} failed
END
Loading