Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-14416 - Implement check for missing tests #1951

Merged
merged 1 commit into from
Oct 24, 2024
Merged

RHOAIENG-14416 - Implement check for missing tests #1951

merged 1 commit into from
Oct 24, 2024

Conversation

jiripetrlik
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 22, 2024
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -212,6 +212,12 @@
... env:PIP_INDEX_URL=${PIP_INDEX_URL}
... env:PIP_TRUSTED_HOST=${PIP_TRUSTED_HOST}
Log To Console ${result.stdout}
Check missing Go test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
IF ${result.rc} != 0
FAIL ${TEST_NAME} failed
END

Check missing Go test

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
...sts/0600__distributed_workloads/0601__workloads_orchestration/test-run-kueue-e2e-tests.robot
@@ -81,6 +81,7 @@
... env:NAMESPACE=${APPLICATIONS_NAMESPACE}
... env:SKIP_JOB_SET_AVAILABILITY_CHECK=true
Log To Console ${result.stdout}
Check missing test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing test' does not follow case convention
...sts/0600__distributed_workloads/0601__workloads_orchestration/test-run-kueue-e2e-tests.robot
@@ -95,6 +96,12 @@
... env:NAMESPACE=${APPLICATIONS_NAMESPACE}
... env:SKIP_JOB_SET_AVAILABILITY_CHECK=true
Log To Console ${result.stdout}
Check missing test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing test' does not follow case convention
...sts/0600__distributed_workloads/0601__workloads_orchestration/test-run-kueue-e2e-tests.robot
IF ${result.rc} != 0
FAIL failed
END

Check missing test

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing test' does not follow case convention
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
554 0 0 554 100

Srihari1192
Srihari1192 previously approved these changes Oct 22, 2024
View reviewed changes
@ChughShilpa
Copy link
Contributor

ChughShilpa commented Oct 22, 2024 •
edited
Loading

Thanks @jiripetrlik for adding the check for missing tests
This check also needs to add for kuberay tests

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 24, 2024
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -149,6 +149,7 @@
... env:CODEFLARE_TEST_OUTPUT_DIR=%{WORKSPACE}/codeflare-${test_binary}-logs
... env:FMS_HF_TUNING_IMAGE=${FMS_HF_TUNING_IMAGE}
Log To Console ${result.stdout}
Check missing Go test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-run-kuberay-e2e.robot
@@ -85,6 +86,7 @@
... timeout=20m
... stdout=${TEMPDIR}/output.txt
Log To Console ${result.stdout}
Check missing Go test ${result.stdout}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check missing Go test' does not follow case convention
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jiripetrlik
Copy link
Contributor Author

@ChughShilpa Added check also for Ray and TrainingOperator tests.

ChughShilpa
ChughShilpa approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jiripetrlik jiripetrlik merged commit 8fd9845 into red-hat-data-services:master Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChughShilpa ChughShilpa ChughShilpa approved these changes

@sutaakar sutaakar sutaakar approved these changes

@Srihari1192 Srihari1192 Srihari1192 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiripetrlik @ChughShilpa @sutaakar @Srihari1192