Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase logo's timeout #1904

Merged
merged 4 commits into from
Oct 9, 2024
Merged

fix: increase logo's timeout #1904

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea65f6c
fix: ODS-2206, wrong pipelines xpath
FedeAlonso Sep 30, 2024
336540b
Merge branch 'master' of github.com:red-hat-data-services/ods-ci
FedeAlonso Oct 7, 2024
608d3f8
fix: increase timeout for logo
FedeAlonso Oct 9, 2024
bbb78df
Merge branch 'master' into fix/increase_timeout_for_logo
FedeAlonso Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Wait For RHODS Dashboard To Load
... ${expected_page}=${NONE} ${timeout}=60
${half_timeout}= Evaluate int(${timeout}) / 2
Wait For Condition return document.title == ${dashboard_title} timeout=${half_timeout}
Wait Until Page Contains Element xpath:${RHODS_LOGO_XPATH} timeout=${half_timeout}
Wait Until Page Contains Element xpath:${RHODS_LOGO_XPATH} timeout=${timeout}
Copy link
Member

@jstourac jstourac Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedeAlonso now this waits for timeout + half_timeout that is given to this keyword... this can be confusing for someone

IF "${expected_page}" == "${NONE}"
Wait Until Page Contains Element //div[@data-testid="home-page"] timeout=${half_timeout}
ELSE
Expand Down
Loading