fix: increase logo's timeout #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeAlonso
added
verified
FedeAlonso
requested review from
jgarciao,
manosnoam,
jstourac,
CFSNM,
lugi0,
ConorOM1 and
asanzgom
mwaykole
approved these changes
Oct 9, 2024
|
Robot Results
|
jiridanek
approved these changes
Oct 9, 2024
jstourac
reviewed
Oct 9, 2024
| @@ -99,7 +99,7 @@ Wait For RHODS Dashboard To Load | |||
| ... ${expected_page}=${NONE} ${timeout}=60 | |||
| ${half_timeout}= Evaluate int(${timeout}) / 2 | |||
| Wait For Condition return document.title == ${dashboard_title} timeout=${half_timeout} | |||
| Wait Until Page Contains Element xpath:${RHODS_LOGO_XPATH} timeout=${half_timeout} | |||
| Wait Until Page Contains Element xpath:${RHODS_LOGO_XPATH} timeout=${timeout} | |||
There was a problem hiding this comment.
@FedeAlonso now this waits for timeout + half_timeout that is given to this keyword... this can be confusing for someone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-14148
During the last nightlies, there's always some dashboard setup which fails due to the Logo not loading quickly (this just happen in freshly installed operators).
We are incresing the timeout for the logo.