Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customRayImage test #1836

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add customRayImage test #1836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
${CODEFLARE-SDK_DIR} codeflare-sdk
${CODEFLARE-SDK_REPO_URL} %{CODEFLARE-SDK_REPO_URL=https://github.com/project-codeflare/codeflare-sdk.git}
${DISTRIBUTED_WORKLOADS_RELEASE_ASSETS} https://github.com/opendatahub-io/distributed-workloads/releases/latest/download
${RAY_IMAGE} quay.io/rhoai/ray@sha256:859f5c41d41bad1935bce455ad3732dff9d4d4c342b7155a7cd23809e85698ab
${FMS_HF_TUNING_IMAGE} quay.io/modh/fms-hf-tuning@sha256:8edea6f0f9c4c631cdca1e1c10abf0d4b994738fde78c40d48eda216fdd382f5
${NOTEBOOK_IMAGE} quay.io/modh/odh-generic-data-science-notebook@sha256:9d7f80080a453bcf7dee01b986df9ee811ee74f6f433c601a8b67d283c160547
${NOTEBOOK_USER_NAME} ${TEST_USER_3.USERNAME}
Expand Down Expand Up @@ -189,6 +188,7 @@
Restart Kueue

Log To Console "Downloading compiled test binary ${ODH_BINARY_NAME}"

${result} = Run Process curl --location --silent --output ${ODH_BINARY_NAME} ${DISTRIBUTED_WORKLOADS_RELEASE_ASSETS}/${ODH_BINARY_NAME} && chmod +x ${ODH_BINARY_NAME}
... shell=true
... stderr=STDOUT
Expand Down Expand Up @@ -222,7 +222,7 @@

Run Codeflare ODH Test
[Documentation] Run Codeflare ODH Test
[Arguments] ${TEST_NAME}
[Arguments] ${TEST_NAME} ${RAY_IMAGE}

Check warning

Code scanning / Robocop

{{ var_or_arg }} '{{ variable_name }}' overwrites reserved variable '{{ reserved_variable }}' Warning test

Argument '${TEST_NAME}' overwrites reserved variable '${TEST_NAME}'
Log To Console "Running test: ${TEST_NAME}"
${result} = Run Process ./${ODH_BINARY_NAME} -test.run ${TEST_NAME}
... shell=true
Expand Down
32 changes: 28 additions & 4 deletions ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-run-codeflare-tests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
Resource ../../../../tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource


*** Variables ***
${RAY_CUDA_IMAGE} quay.io/modh/ray@sha256:4575dd54fe05213fe9228cd316d5e87a9395cd16b618a85a94995709e5f3aaeb

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (125/120)
${RAY_TORCH_CUDA_IMAGE} quay.io/rhoai/ray@sha256:158b481b8e9110008d60ac9fb8d156eadd71cb057ac30382e62e3a231ceb39c0

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (126/120)


*** Test Cases ***
Run TestKueueRayCpu ODH test
[Documentation] Run Go ODH test: TestKueueRayCpu
Expand All @@ -16,7 +21,7 @@
... DistributedWorkloads
... Training
... CodeflareOperator
Run Codeflare ODH Test TestMnistRayCpu
Run Codeflare ODH Test TestMnistRayCpu ${RAY_CUDA_IMAGE}

Run TestKueueRayGpu ODH test
[Documentation] Run Go ODH test: TestKueueRayGpu
Expand All @@ -25,7 +30,7 @@
... DistributedWorkloads
... Training
... CodeflareOperator
Run Codeflare ODH Test TestMnistRayGpu
Run Codeflare ODH Test TestMnistRayGpu ${RAY_CUDA_IMAGE}

Run TestRayTuneHPOCpu ODH test
[Documentation] Run Go ODH test: TestMnistRayTuneHpoCpu
Expand All @@ -34,7 +39,7 @@
... DistributedWorkloads
... Training
... CodeflareOperator
Run Codeflare ODH Test TestMnistRayTuneHpoCpu
Run Codeflare ODH Test TestMnistRayTuneHpoCpu ${RAY_CUDA_IMAGE}

Run TestRayTuneHPOGpu ODH test
[Documentation] Run Go ODH test: TestMnistRayTuneHpoGpu
Expand All @@ -43,4 +48,23 @@
... DistributedWorkloads
... Training
... CodeflareOperator
Run Codeflare ODH Test TestMnistRayTuneHpoGpu
Run Codeflare ODH Test TestMnistRayTuneHpoGpu ${RAY_CUDA_IMAGE}

Run TestKueueCustomRayCpu ODH test
[Documentation] Run Go ODH test: TestKueueCustomRayCpu
[Tags] RHOAIENG-10013
... Tier1
... DistributedWorkloads
... Training
... CodeflareOperator
Run Codeflare ODH Test TestMnistCustomRayImageCpu ${RAY_TORCH_CUDA_IMAGE}

Run TestKueueCustomRayGpu ODH test
[Documentation] Run Go ODH test: TestKueueCustomRayGpu
[Tags] RHOAIENG-10013
... Resources-GPU
... Tier1
... DistributedWorkloads
... Training
... CodeflareOperator
Run Codeflare ODH Test TestMnistCustomRayImageGpu ${RAY_TORCH_CUDA_IMAGE}
Loading