Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customRayImage test #1836

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add customRayImage test #1836

merged 1 commit into from
Sep 23, 2024

Conversation

ChughShilpa
Copy link
Contributor

Closes issue

@ChughShilpa
Copy link
Contributor Author

All codeflare-operator tests passed here -
rhoai-test-flow/418

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2024
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -222,7 +222,7 @@

Run Codeflare ODH Test
[Documentation] Run Codeflare ODH Test
[Arguments] ${TEST_NAME}
[Arguments] ${TEST_NAME} ${RAY_IMAGE}

Check warning

Code scanning / Robocop

{{ var_or_arg }} '{{ variable_name }}' overwrites reserved variable '{{ reserved_variable }}' Warning test

Argument '${TEST_NAME}' overwrites reserved variable '${TEST_NAME}'
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-run-codeflare-tests.robot
@@ -8,6 +8,11 @@
Resource ../../../../tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource


*** Variables ***
${RAY_CUDA_IMAGE} quay.io/modh/ray@sha256:4575dd54fe05213fe9228cd316d5e87a9395cd16b618a85a94995709e5f3aaeb

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (125/120)
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-run-codeflare-tests.robot
@@ -8,6 +8,11 @@
Resource ../../../../tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource


*** Variables ***
${RAY_CUDA_IMAGE} quay.io/modh/ray@sha256:4575dd54fe05213fe9228cd316d5e87a9395cd16b618a85a94995709e5f3aaeb
${RAY_TORCH_CUDA_IMAGE} quay.io/rhoai/ray@sha256:158b481b8e9110008d60ac9fb8d156eadd71cb057ac30382e62e3a231ceb39c0

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (126/120)
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
543 0 0 543 100

@ChughShilpa ChughShilpa force-pushed the Add_custom_image_ray_test branch from 4199ac5 to 05a43a1 Compare September 20, 2024 13:20
@ChughShilpa ChughShilpa force-pushed the Add_custom_image_ray_test branch from 05a43a1 to f7236e7 Compare September 23, 2024 05:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sutaakar sutaakar merged commit 0959142 into red-hat-data-services:master Sep 23, 2024
10 checks passed
@ChughShilpa ChughShilpa deleted the Add_custom_image_ray_test branch September 23, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar approved these changes

@abhijeet-dhumal abhijeet-dhumal abhijeet-dhumal approved these changes

@jiripetrlik jiripetrlik Awaiting requested review from jiripetrlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChughShilpa @sutaakar @abhijeet-dhumal