Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up execution of keyword "Is RHODS Self-Managed" in local #1366

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Speed-up execution of keyword "Is RHODS Self-Managed" in local #1366

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc3cc9c
Speed up keyword "Is RHODS Self-Managed"
jgarciao Apr 9, 2024
d353471
Fix new robocop warning
jgarciao Apr 9, 2024
1d4e8cb
Add comment about the reasons not to use OpenShift library
jgarciao Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ods_ci/tests/Resources/OCP.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,8 @@
... in the cluster (e.g., usually on OSD, ROSA).
... Returns ${TRUE} if RHODS Self-Managed is installed or if PRODUCT=ODH
IF "${PRODUCT}" == "ODH" RETURN ${TRUE}
${is_managed} = Run Keyword And Return Status OpenshiftLibrary.Oc Get
... kind=CatalogSource
... name=addon-managed-odh-catalog
... namespace=${OPERATOR_NAMESPACE}
Run Keyword And Return Evaluate not ${is_managed}
${rc}= Run And Return Rc oc get catalogsource addon-managed-odh-catalog -n ${OPERATOR_NAMESPACE}
jgarciao marked this conversation as resolved.
Show resolved Hide resolved
Run Keyword And Return Run Keyword And Return Status Should Not Be Equal As Numbers ${rc} ${0}

Get MachineSets
[Documentation] Returns a list of machinesets names
Expand Down Expand Up @@ -223,8 +220,8 @@
${match_list} Get Regexp Matches ${pod_logs} ${regex_pattern}
${entry_msg} Remove Duplicates ${match_list}
${length} Get Length ${entry_msg}
IF ${length} != ${0} FAIL Pod ${pod_name} logs should not contain regexp ${regex_pattern}. Matching log entry: ${entry_msg}
IF ${length} != ${0} FAIL Pod ${pod_name} logs should not contain regexp ${regex_pattern}. Matching log entry: ${entry_msg}
Dismissed Show dismissed Hide dismissed
... ELSE Log message=Pod ${pod_name} logs does not contain regexp ${regex_pattern} level=INFO

Check warning

Code scanning / Robocop

Avoid splitting inline IF to multiple lines Warning test

Avoid splitting inline IF to multiple lines

Is Resource Present
[Documentation] Check If Resource Is Present In Namespace
Expand Down
Loading