Speed-up execution of keyword "Is RHODS Self-Managed" in local #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHOSi Setup is calling the keyword "Is RHODS Self-Managed", which is currently using the Robot Framework OpenShiftLibrary. The problem is that this library takes more than 10s to load, slowing down development in local. This PR modifies the keyword not to use that library in this particular keyword Signed-off-by: Jorge Garcia Oncins <[email protected]>
jgarciao
added
the
enhancements
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Robot Results
|
Signed-off-by: Jorge Garcia Oncins <[email protected]>
jiridanek
previously approved these changes
Apr 9, 2024
FedeAlonso
previously approved these changes
Apr 9, 2024
jstourac
reviewed
Apr 9, 2024
Signed-off-by: Jorge Garcia Oncins <[email protected]>
|
FedeAlonso
approved these changes
Apr 9, 2024
jiridanek
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyword
RHOSi Setupcalls keywordIs RHODS Self-Managed, which is using the Robot Framework OpenShiftLibrary to performOc Get ...The problem is that the OpenShiftLibrary library takes more than 10s to load for the first time, slowing down development in local.
This PR modifies the
Is RHODS Self-Managedkeyword not to use the OpenShift Library in order to speed up execution.Tested successfully in local and rhods-ci-pr-test/2683
Original:
With this PR:
