Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ODS-282 Verify Content In RHODS Explore Section #1280

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: ODS-282 Verify Content In RHODS Explore Section #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ods_ci/tests/Resources/Files/AppsInfoDictionary_latest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@
"matching": ""
},
"1": {
"text": "Enabling GPU Support in Openshift Data Science",
"text": "Enabling GPU Support in OpenShift AI",
"url": "https://access.redhat.com/documentation/en-us/red_hat_openshift_data_science/1/html/managing_users_and_user_resources/enabling-gpu-support-in-openshift-data-science_user-mgmt",
"matching": ""
}
Expand Down
8 changes: 4 additions & 4 deletions ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
${ODH_DASHBOARD_SIDEBAR_HEADER_ENABLE_BUTTON}= //*[@class="pf-v5-c-drawer__panel-main"]//button[.='Enable']
${ODH_DASHBOARD_SIDEBAR_HEADER_GET_STARTED_ELEMENT}= //*[@class="pf-v5-c-drawer__panel-main"]//*[.='Get started']
${CARDS_XP}= //*[(contains(@class, 'odh-card')) and (contains(@class, 'pf-v5-c-card'))]
${CARD_BUTTON_XP}= ..//input[@class="pf-v5-c-radio__input"][@name="odh-explore-selectable-card"]
${CARD_BUTTON_XP}= //input[@class="pf-v5-c-radio__input"][@name="odh-explore-selectable-card"]
${RES_CARDS_XP}= //div[contains(@data-ouia-component-type, "Card")]
${SAMPLE_APP_CARD_XP}= //*[@id="pachyderm-selectable-card-id"]
${HEADER_XP}= div[@class='pf-v5-c-card__header']
Expand Down Expand Up @@ -337,9 +337,9 @@

Open Get Started Sidebar And Return Status
[Arguments] ${card_locator}
Wait Until Element Is Visible xpath:${card_locator}/${CARD_BUTTON_XP}
Wait Until Element Is Enabled xpath:${card_locator}/${CARD_BUTTON_XP} timeout=20s error=Element is not clickbale #robocop : disable
${element}= Get WebElement xpath:${card_locator}/${CARD_BUTTON_XP}
Wait Until Element Is Visible xpath:${card_locator}${CARD_BUTTON_XP}
Wait Until Element Is Enabled xpath:${card_locator}${CARD_BUTTON_XP} timeout=20s error=Element is not clickbale #robocop : disable

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (146/120)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a cheap fix

Check warning

Code scanning / Robocop

Missing blank space after comment character Warning test

Missing blank space after comment character
${element}= Get WebElement xpath:${card_locator}${CARD_BUTTON_XP}
Execute Javascript arguments[0].click(); ARGUMENTS ${element}
${status}= Run Keyword and Return Status Wait Until Page Contains Element xpath://div[contains(@class,'pf-v5-c-drawer__panel-main')]
Sleep 1
Expand Down
Loading