fix: ODS-282 Verify Content In RHODS Explore Section #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeAlonso
added
verified
FedeAlonso
requested review from
jgarciao,
manosnoam,
jstourac,
lugi0,
bdattoma and
asanzgom
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Wait Until Element Is Enabled xpath:${card_locator}/${CARD_BUTTON_XP} timeout=20s error=Element is not clickbale #robocop : disable | ||
| ${element}= Get WebElement xpath:${card_locator}/${CARD_BUTTON_XP} | ||
| Wait Until Element Is Visible xpath:${card_locator}${CARD_BUTTON_XP} | ||
| Wait Until Element Is Enabled xpath:${card_locator}${CARD_BUTTON_XP} timeout=20s error=Element is not clickbale #robocop : disable |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| Wait Until Element Is Enabled xpath:${card_locator}/${CARD_BUTTON_XP} timeout=20s error=Element is not clickbale #robocop : disable | ||
| ${element}= Get WebElement xpath:${card_locator}/${CARD_BUTTON_XP} | ||
| Wait Until Element Is Visible xpath:${card_locator}${CARD_BUTTON_XP} | ||
| Wait Until Element Is Enabled xpath:${card_locator}${CARD_BUTTON_XP} timeout=20s error=Element is not clickbale #robocop : disable |
Check warning
Code scanning / Robocop
Missing blank space after comment character Warning test
Robot Results
|
jstourac
approved these changes
Mar 12, 2024
asanzgom
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test "fix: ODS-282 Verify Content In RHODS Explore Section" was failing in 2.8 RC2 due to:
After fixing it we found another 2 issues:
Now we just have the wrong Intel links, which has been already notified:
