Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with model path #1264

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix the issue with model path #1264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d5608
Fix the issue with model path
tarukumar Mar 7, 2024
efd44b7
chnaged based on sugestion
tarukumar Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ods_ci/tests/Resources/CLI/ModelServing/llm.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,17 @@
... ${download_in_pvc}=${FALSE} ${storage_size}=70Gi ${model_name}=${NONE} ${model_path}=${NONE} ${download_timeout}=600s
Set Up Test OpenShift Project test_ns=${namespace}
IF ${download_in_pvc}
Create PVC And Download Model From S3 model_name=${model_name} namespace=${namespace} bucket_name=${MODELS_BUCKET.NAME}
... endpoint=${MODELS_BUCKET.ENDPOINT} region=${MODELS_BUCKET.REGION} access_key_id=${S3.AWS_ACCESS_KEY_ID}
... access_key=${S3.AWS_SECRET_ACCESS_KEY} use_https=${USE_BUCKET_HTTPS} download_timeout=${download_timeout}
... storage_size=${storage_size} model_path=${model_path}
IF ${model_path} == ${NONE}
Create PVC And Download Model From S3 model_name=${model_name} namespace=${namespace} bucket_name=${MODELS_BUCKET.NAME}
Fixed Show fixed Hide fixed
... endpoint=${MODELS_BUCKET.ENDPOINT} region=${MODELS_BUCKET.REGION} access_key_id=${S3.AWS_ACCESS_KEY_ID}
Fixed Show fixed Hide fixed
... access_key=${S3.AWS_SECRET_ACCESS_KEY} use_https=${USE_BUCKET_HTTPS} download_timeout=${download_timeout}
Fixed Show fixed Hide fixed
... storage_size=${storage_size} model_path=${model_name}
ELSE
Create PVC And Download Model From S3 model_name=${model_name} namespace=${namespace} bucket_name=${MODELS_BUCKET.NAME}
Fixed Show fixed Hide fixed
Fixed Show fixed Hide fixed
... endpoint=${MODELS_BUCKET.ENDPOINT} region=${MODELS_BUCKET.REGION} access_key_id=${S3.AWS_ACCESS_KEY_ID}
Fixed Show fixed Hide fixed
... access_key=${S3.AWS_SECRET_ACCESS_KEY} use_https=${USE_BUCKET_HTTPS} download_timeout=${download_timeout}
Fixed Show fixed Hide fixed
... storage_size=${storage_size} model_path=${model_path}
END
tarukumar marked this conversation as resolved.
Show resolved Hide resolved
ELSE
Create Secret For S3-Like Buckets endpoint=${endpoint}
... region=${MODELS_BUCKET.REGION} namespace=${namespace}
Expand Down
Loading