Fix the issue with model path #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Kumar <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Robot Results
|
bdattoma
reviewed
Mar 7, 2024
tarukumar
added
the
enhancements
Signed-off-by: Tarun Kumar <[email protected]>
|
| @@ -59,7 +59,7 @@ | |||
| [Arguments] ${namespace} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime ${protocol}=grpc | |||
| ... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY} | |||
| ... ${endpoint}=${MODELS_BUCKET.ENDPOINT} ${verify_ssl}=${TRUE} | |||
| ... ${download_in_pvc}=${FALSE} ${storage_size}=70Gi ${model_name}=${NONE} ${model_path}=${NONE} ${download_timeout}=600s | |||
| ... ${download_in_pvc}=${FALSE} ${storage_size}=70Gi ${model_name}=${NONE} ${model_path}=${model_name} ${download_timeout}=600s | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| @@ -59,7 +59,7 @@ | |||
| [Arguments] ${namespace} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime ${protocol}=grpc | |||
| ... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY} | |||
| ... ${endpoint}=${MODELS_BUCKET.ENDPOINT} ${verify_ssl}=${TRUE} | |||
| ... ${download_in_pvc}=${FALSE} ${storage_size}=70Gi ${model_name}=${NONE} ${model_path}=${NONE} ${download_timeout}=600s | |||
| ... ${download_in_pvc}=${FALSE} ${storage_size}=70Gi ${model_name}=${NONE} ${model_path}=${model_name} ${download_timeout}=600s | |||
Check notice
Code scanning / Robocop
There is too many arguments per continuation line ({{ arguments_count }} / {{ max_arguments_count }}) Note test
mwaykole
approved these changes
Mar 7, 2024
lugi0
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed tha the older tc which doesn't have model path paramter in it was failing while downloading the model