Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cluster_id instead of cluster_name with ocm command #1237

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

kobihk
Copy link
Contributor

@kobihk kobihk commented Feb 29, 2024

➜ ocm list machinepools --cluster ods-qe-rosa-01
Error: Failed to get cluster 'ods-qe-rosa-01': There are 3 subscriptions with cluster identifier or name 'ods-qe-rosa-01'

➜ ocm list idps --cluster ods-qe-rosa-01
Error: Failed to get cluster 'ods-qe-rosa-01': There are 3 subscriptions with cluster identifier or name 'ods-qe-rosa-01'

➜ ocm --v=0 delete user xxx --cluster ods-qe-rosa-01 --group=cluster-admins
Error: Failed to get cluster 'ods-qe-rosa-01': There are 3 subscriptions with cluster identifier or name 'ods-qe-rosa-01'

This fix using the cluster_id instead of the cluster_name

followup of #1056

related to jira ticket: RHOAIENG-3878

@kobihk kobihk requested review from jstourac, jiridanek, manosnoam and aloganat and removed request for manosnoam February 29, 2024 11:32
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
429 0 0 429 100

@kobihk kobihk force-pushed the use_cluster_id_master branch from a2174ad to 87d1aba Compare February 29, 2024 11:36
@kobihk kobihk requested a review from FedeAlonso February 29, 2024 12:31
@kobihk kobihk force-pushed the use_cluster_id_master branch from 87d1aba to f2fb01a Compare February 29, 2024 13:03
@kobihk kobihk force-pushed the use_cluster_id_master branch from f2fb01a to 0397a44 Compare February 29, 2024 14:41
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still mixing functional and refactoring changes in same commit but LGTM 🙂

@kobihk kobihk merged commit 7e4a6e8 into red-hat-data-services:master Feb 29, 2024
11 checks passed
@kobihk kobihk deleted the use_cluster_id_master branch February 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants