Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always describe clusters with ID #1056

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

apodhrad
Copy link
Contributor

No description provided.

@apodhrad apodhrad changed the title Always describe clusters with ID WIP: Always describe clusters with ID Nov 30, 2023
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
372 0 0 372 100

@apodhrad apodhrad changed the title WIP: Always describe clusters with ID Always describe clusters with ID Nov 30, 2023
@jgarciao jgarciao added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Dec 1, 2023
aloganat
aloganat previously approved these changes Dec 1, 2023
Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kornys
kornys previously approved these changes Dec 2, 2023
FedeAlonso
FedeAlonso previously approved these changes Dec 4, 2023
jstourac
jstourac previously approved these changes Dec 4, 2023
@apodhrad
Copy link
Contributor Author

apodhrad commented Dec 4, 2023

The job for rosa installation is still failing. It seem that it was caused by something else but we need to be sure

@apodhrad apodhrad changed the title Always describe clusters with ID WIP: Always describe clusters with ID Dec 4, 2023
@apodhrad apodhrad dismissed stale reviews from jstourac, FedeAlonso, kornys, and aloganat via 8136de0 December 4, 2023 15:05
@apodhrad apodhrad changed the title WIP: Always describe clusters with ID Always describe clusters with ID Dec 4, 2023
Signed-off-by: Andrej Podhradsky <[email protected]>
Copy link

sonarqubecloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@apodhrad
Copy link
Contributor Author

apodhrad commented Dec 4, 2023

There was a small issue which I have fixed and also verified with the OSD cluster creation at
https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods/job/rhods-smoke/4117/consoleFull

@apodhrad apodhrad removed the needs testing Needs to be tested in Jenkins label Dec 5, 2023
@aloganat aloganat merged commit 3a4fd15 into red-hat-data-services:master Dec 6, 2023
6 of 8 checks passed
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
kobihk added a commit that referenced this pull request Feb 29, 2024
➜ ocm list machinepools --cluster ods-qe-rosa-01
Error: Failed to get cluster 'ods-qe-rosa-01': There are 3 subscriptions
with cluster identifier or name 'ods-qe-rosa-01'

➜ ocm list idps --cluster ods-qe-rosa-01
Error: Failed to get cluster 'ods-qe-rosa-01': There are 3 subscriptions
with cluster identifier or name 'ods-qe-rosa-01'

➜ ocm --v=0 delete user xxx --cluster ods-qe-rosa-01
--group=cluster-admins
Error: Failed to get cluster 'ods-qe-rosa-01': There are 3 subscriptions
with cluster identifier or name 'ods-qe-rosa-01'

This fix using the cluster_id instead of the cluster_name

followup of #1056

related to jira ticket: RHOAIENG-3878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants