[Fix] jupyter notebook spawn checks #1228
Conversation
Robot Results
|
jstourac
force-pushed
the
fixJupyterSpawn
branch
from
1d397b3 to
349d120
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [Arguments] ${image_name} ${version} | ||
| ${ide}= Notebook Expected Ide ${image_name} | ||
| [Arguments] ${image} ${version} | ||
| ${ide}= Notebook Expected Ide ${image} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
This is a fix for the recent change [1,2]. Let's be consistent in the variable naming in all relevant keywords. * [1] red-hat-data-services#1102 * [2] 60fffb5
jstourac
force-pushed
the
fixJupyterSpawn
branch
from
349d120 to
765adb6
Compare
jstourac
changed the title
|
jiridanek
added
verified
| [Arguments] ${image_name} ${version} | ||
| ${ide}= Notebook Expected Ide ${image_name} | ||
| [Arguments] ${image} ${version} | ||
| ${ide}= Notebook Expected Ide ${image} |
There was a problem hiding this comment.
you're just changing variable name, what is this PR fixing?
There was a problem hiding this comment.
Few lines below, there was just image used in the method, which didn't work with the current state. My first intention was to rename that variable to image_name also, but then I realised that everywhere else we use just image...
There was a problem hiding this comment.
Ah, it's hidden bcos unchanged. Ok thanks
I agree, but everywhere else there is used just |
This is a fix for the recent change [1,2]
CI: