New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHOAIENG-223] Test VSCode - add checks for VS Code image #1102

Merged

jstourac merged 1 commit into red-hat-data-services:master from jstourac:vscode

Feb 22, 2024

Member

jstourac commented Jan 9, 2024 •

edited

Loading

This introduces tests for the recently added VS Code IDE image. For more information see [1,2].

[1] https://issues.redhat.com/browse/RHOAIENG-223
[2] https://issues.redhat.com/browse/RHOAIENG-225

CI: rhods-ci-pr-test/2349

jstourac self-assigned this

github-advanced-security bot found potential problems

View reviewed changes

ods_ci/tests/Tests/500__jupyterhub/minimal-vscode-test.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot

    
                  [Documentation]  Waits for the notebook IDE environment to be loaded completely and performs

                  ...              a simple check with the Menu action in the loaded IDE.

                  [Arguments]  ${image_name}  ${version}

                  ${ide}=  Notebook Expected Ide  ${image_name}

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected ' =' but got '=' instead

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

Contributor

github-actions bot commented Jan 9, 2024 •

edited

Loading

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
425	0	0	425	100

jstourac force-pushed the vscode branch from fdae431 to a7afb2d Compare

January 11, 2024 12:57

github-advanced-security bot found potential problems

View reviewed changes

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Fixed Show fixed Hide fixed

jiridanek previously approved these changes

View reviewed changes

Member

jiridanek commented Jan 15, 2024

+1 I think it makes sense merging just the spawning test, after a little cleanup.

jstourac force-pushed the vscode branch from a7afb2d to b410aea Compare

January 18, 2024 08:08

jstourac dismissed jiridanek’s stale review via

9eab353

January 19, 2024 15:23

jstourac force-pushed the vscode branch from b410aea to 9eab353 Compare

January 19, 2024 15:23

github-advanced-security bot found potential problems

View reviewed changes

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot

    
            @@ -41,6 +41,28 @@
          
                  ...    project_title=${PRJ_TITLE}    username=${TEST_USER_3.USERNAME}

                  ...    password=${TEST_USER_3.PASSWORD}    auth_type=${TEST_USER_3.AUTH_TYPE}

              Verify User Can Create A Workbench Using Code Server Image

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Verify User Can Create A Workbench Using Code Server Image' has too many keywords inside (11/10)

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed

jstourac added new test verified labels

jstourac marked this pull request as ready for review

January 19, 2024 16:06

jstourac requested review from jiridanek and bdattoma

January 19, 2024 16:06

bdattoma reviewed

View reviewed changes

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot Outdated Show resolved Hide resolved

bdattoma reviewed

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Projects.resource Outdated Show resolved Hide resolved

bdattoma reviewed

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource Outdated Show resolved Hide resolved

bdattoma reviewed

View reviewed changes

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Show resolved Hide resolved

jstourac force-pushed the vscode branch 2 times, most recently from 0cd8562 to 76664b7 Compare

January 19, 2024 17:25

bdattoma reviewed

View reviewed changes

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Show resolved Hide resolved

jstourac force-pushed the vscode branch 2 times, most recently from 704b0fa to 68a6d39 Compare

February 12, 2024 10:32

github-advanced-security bot found potential problems

View reviewed changes

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed

jstourac force-pushed the vscode branch from 68a6d39 to a47dcc3 Compare

February 12, 2024 12:50

github-advanced-security bot found potential problems

View reviewed changes

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot

    
              Verify User Can Create A Workbench Using Code Server Image

                  [Documentation]    Verifies that a workbench can be created using Code Server image

                  [Tags]    Sanity    Tier1

                  Set Test Variable   ${IMG_NAME}    code-server

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Test Variable can be replaced with VAR

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot

    
                  [Documentation]    Verifies that a workbench can be created using Code Server image

                  [Tags]    Sanity    Tier1

                  Set Test Variable   ${IMG_NAME}    code-server

                  Set Test Variable   ${WORKBENCH_TITLE}    codeServer

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Test Variable can be replaced with VAR

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot

    
                  [Tags]    Sanity    Tier1

                  Set Test Variable   ${IMG_NAME}    code-server

                  Set Test Variable   ${WORKBENCH_TITLE}    codeServer

                  Set Test Variable   ${PV_NAME}    codeServerPv

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Test Variable can be replaced with VAR

..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot

    
                  Set Test Variable   ${IMG_NAME}    code-server

                  Set Test Variable   ${WORKBENCH_TITLE}    codeServer

                  Set Test Variable   ${PV_NAME}    codeServerPv

                  Set Test Variable   ${PV_DESCRIPTION}    PV for codeServer

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Test Variable can be replaced with VAR

bdattoma reviewed

View reviewed changes

ods_ci/tests/Tests/500__jupyterhub/minimal-vscode-test.robot Outdated

    
              Close Previous Server

                  [Documentation]  Closes previous server and goes back to Spawner

                  Clean Up Server

                  Stop JupyterLab Notebook Server

Contributor

bdattoma Feb 12, 2024

does it work for VS Code as well?

Member Author

jstourac Feb 12, 2024 •

edited

Loading

yeah, no... good catch! It isn't being called at all, actually 🙁 let me check

Member Author

jstourac Feb 22, 2024

Updated - I removed this part completely and changed the teardown method at the beginning of the file that stops the created workbench at the end of the test execution.

bdattoma self-requested a review

February 12, 2024 13:09

bdattoma previously approved these changes

View reviewed changes

jstourac marked this pull request as draft

February 20, 2024 11:36

jstourac dismissed bdattoma’s stale review via

6b69d3f

February 22, 2024 09:03

jstourac force-pushed the vscode branch from a47dcc3 to 6b69d3f Compare

February 22, 2024 09:03

github-advanced-security bot found potential problems

View reviewed changes

ods_ci/tests/Resources/Common.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Common.robot Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Common.robot

    
              End Non JupyterLab Web Test

                  [Arguments]    ${username}=${TEST_USER.USERNAME}

                  Go To  ${ODH_DASHBOARD_URL}

                  Wait for RHODS Dashboard to Load

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Wait for RHODS Dashboard to Load' does not follow case convention

jstourac marked this pull request as ready for review

February 22, 2024 09:04


          [RHOAIENG-223] Test VSCode - add checks for VS Code image

59120e7

This introduces tests for the recently added code-server IDE image. For more
information see [1,2].

This is just a basic check. More should be implemented later.

[1] https://issues.redhat.com/browse/RHOAIENG-223
[2] https://issues.redhat.com/browse/RHOAIENG-225

jstourac force-pushed the vscode branch from 6b69d3f to 59120e7 Compare

February 22, 2024 09:06

sonarqubecloud bot commented Feb 22, 2024

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

bdattoma reviewed

View reviewed changes

ods_ci/tests/Resources/Common.robot Show resolved Hide resolved

bdattoma approved these changes

View reviewed changes

jiridanek approved these changes

View reviewed changes

jstourac merged commit 60fffb5 into red-hat-data-services:master

11 checks passed

jstourac deleted the vscode branch

February 22, 2024 09:38

jstourac mentioned this pull request

[Fix] jupyter notebook spawn checks #1228

Merged

jstourac added a commit to jstourac/ods-ci that referenced this pull request


          [Fix] jupyter notebook spawn checks

765adb6

This is a fix for the recent change [1,2]. Let's be consistent in the
variable naming in all relevant keywords.

* [1] red-hat-data-services#1102
* [2] 60fffb5

jstourac added a commit that referenced this pull request


          [Fix] jupyter notebook spawn checks

410104c

This is a fix for the recent change [1,2]. Let's be consistent in the
variable naming in all relevant keywords.

* [1] #1102
* [2] 60fffb5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new test verified