-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify Pipeline Run Is Completed #1205
Verify Pipeline Run Is Completed #1205
Conversation
Robot Results
|
# Pipeline Run Should Be Listed name=${PIPELINE_TEST_RUN_BASENAME} | ||
# ... pipeline_name=${PIPELINE_TEST_NAME} | ||
|
||
# Verify Pipeline Run Deployment Is Successful project_title=${PRJ_TITLE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Verify Pipeline Run Deployment Is Successful
keyword is now unused? Maybe it should be deleted at
Lines 155 to 190 in 80fd3d9
Verify Pipeline Run Deployment Is Successful # robocop: disable | |
[Documentation] Verifies the correct deployment of the test pipeline run in the rhods namespace. | |
... It checks all the expected pods for the "iris" test pipeline run used in the TC. | |
[Arguments] ${project_title} ${workflow_name} | |
${namespace}= Get Openshift Namespace From Data Science Project | |
... project_title=${PRJ_TITLE} | |
@{data_prep}= Oc Get kind=Pod namespace=${namespace} | |
... label_selector=tekton.dev/taskRun=${workflow_name}-data-prep | |
${containerNames}= Create List step-main step-output-taskrun-name | |
... step-copy-results-artifacts step-move-all-results-to-tekton-home step-copy-artifacts | |
${podStatuses}= Create List Succeeded | |
${containerStatuses}= Create List terminated terminated | |
... terminated terminated terminated | |
Verify Deployment ${data_prep} 1 5 ${containerNames} ${podStatuses} ${containerStatuses} | |
@{train_model}= Oc Get kind=Pod namespace=${namespace} | |
... label_selector=tekton.dev/taskRun=${workflow_name}-train-model | |
${containerNames}= Create List step-main step-output-taskrun-name | |
... step-copy-results-artifacts step-move-all-results-to-tekton-home step-copy-artifacts | |
${podStatuses}= Create List Succeeded | |
${containerStatuses}= Create List terminated terminated | |
... terminated terminated terminated | |
Verify Deployment ${train_model} 1 5 ${containerNames} ${podStatuses} ${containerStatuses} | |
@{eval_model}= Oc Get kind=Pod namespace=${namespace} | |
... label_selector=tekton.dev/taskRun=${workflow_name}-evaluate-model | |
${containerNames}= Create List step-main step-copy-artifacts | |
${podStatuses}= Create List Succeeded | |
${containerStatuses}= Create List terminated terminated | |
... terminated terminated terminated | |
Verify Deployment ${eval_model} 1 2 ${containerNames} ${podStatuses} ${containerStatuses} | |
@{valid_model}= Oc Get kind=Pod namespace=${namespace} | |
... label_selector=tekton.dev/taskRun=${workflow_name}-validate-model | |
${containerNames}= Create List step-main | |
${podStatuses}= Create List Succeeded | |
${containerStatuses}= Create List terminated terminated | |
... terminated terminated terminated | |
Verify Deployment ${valid_model} 1 1 ${containerNames} ${podStatuses} ${containerStatuses} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Will create other PR to remove outdated code. The idea of this PR is to unblock the team because we are working in parallel and those changes are dependent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, then good
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rhods-smoke/4582 |
[Documentation] Open the Pipeline detail and wait for the Completed Status | ||
[Arguments] ${pipeline_run_name} | ||
Open Pipeline Run ${pipeline_run_name} | ||
Wait Until Page Contains Element //span[@class='pf-v5-c-label__text' and text()='Completed'] timeout=10m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest not to pin the xpath to patternfly version, it's less robust
No description provided.