Verify Pipeline Run Is Completed (#1205)

* Verify Pipeline Run Is Completed * Move to other resource * Add Run word
red-hat-data-services · Feb 16, 2024 · 6bb179e · 6bb179e
1 parent 173105a
commit 6bb179e
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 19 deletions.
diff --git a/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataSciencePipelines.resource b/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataSciencePipelines.resource
@@ -131,3 +131,37 @@ Verify There Is No "Error Displaying Pipelines" After Creating Pipeline Server
     ...    Bug: RHOAIENG-2931
     Run Keyword And Ignore Error       Wait Until Page Contains    Error displaying pipelines    timeout=60s
     Run Keyword And Warn On Failure    Page Should Not Contain     Error displaying pipelines
+
+Open Pipeline Detail
+    [Documentation]    Open the Pipeline detail
+    [Arguments]    ${pipeline_name}
+    Wait Until Page Contains Element    xpath=//button[text()='Data Science Pipelines']
+    Click Element    xpath=//button[text()='Data Science Pipelines']
+    Wait Until Page Contains Element    xpath=//a[text()='Pipelines']
+    Click Element    xpath=//a[text()='Pipelines']
+    Wait Until Page Contains Element    xpath=//h2[text()='${pipeline_name}']
+    Click Element    xpath=//button[@id='pipeline-row-item0']
+    Wait Until Page Contains Element    xpath=//a[text()='${pipeline_name}']
+    Click Element    xpath=//a[text()='${pipeline_name}']
+    Wait Until Page Contains Element    xpath=//div[@data-test-id='topology']
+    Capture Page Screenshot
+
+Open Pipeline Run
+    [Documentation]    Open the Pipeline Run detail
+    [Arguments]    ${pipeline_run_name}
+    Wait Until Page Contains Element    xpath=//button[text()='Data Science Pipelines']
+    Click Element    xpath=//button[text()='Data Science Pipelines']
+    Wait Until Page Contains Element    xpath=//a[text()='Runs']
+    Click Element    xpath=//a[text()='Runs']
+    Wait Until Page Contains Element    xpath=//span[text()='Triggered']
+    Click Element    xpath=//span[text()='Triggered']
+    Wait Until Page Contains Element    xpath=//span[text()='${pipeline_run_name}']
+    Click Element    xpath=//span[text()='${pipeline_run_name}']
+    Wait Until Page Contains Element    xpath=//div[@data-test-id='topology']
+
+Verify Pipeline Run Is Completed
+    [Documentation]    Open the Pipeline detail and wait for the Completed Status
+    [Arguments]    ${pipeline_run_name}
+    Open Pipeline Run    ${pipeline_run_name}
+    Wait Until Page Contains Element    //span[@class='pf-v5-c-label__text' and text()='Completed']    timeout=10m
+    Capture Page Screenshot
diff --git a/...Tests/400__ods_dashboard/430__data_science_pipelines/434__data-science-pipelines-ui.robot b/...Tests/400__ods_dashboard/430__data_science_pipelines/434__data-science-pipelines-ui.robot
@@ -70,25 +70,7 @@ Verify User Can Create, Run and Delete A DS Pipeline From DS Project Details Pag
     ${workflow_name}=    Create Pipeline Run    name=${PIPELINE_TEST_RUN_BASENAME}
     ...    pipeline_name=${PIPELINE_TEST_NAME}     run_type=Immediate
 
-    ## TODO: fix keywords checking job status to use Pipelines > Jobs
-    ## instead of the Projec Details Page
-    SeleniumLibrary.Wait Until Page Contains       Running     timeout=10s
-    SeleniumLibrary.Wait Until Page Contains       Completed   timeout=10m
-
-    # TODO: fix following keywords
-    #    Open Data Science Project Details Page    ${PRJ_TITLE}
-    #    Wait Until Pipeline Last Run Is Started    pipeline_name=${PIPELINE_TEST_NAME}
-    #    ...    timeout=10s
-    #  Wait Until Pipeline Last Run Is Finished    pipeline_name=${PIPELINE_TEST_NAME}
-    #    Pipeline Last Run Should Be    pipeline_name=${PIPELINE_TEST_NAME}
-    #    ...    run_name=${PIPELINE_TEST_RUN_BASENAME}
-    #    Pipeline Last Run Status Should Be    pipeline_name=${PIPELINE_TEST_NAME}
-    #    ...    status=Completed
-    #    Pipeline Run Should Be Listed    name=${PIPELINE_TEST_RUN_BASENAME}
-    #    ...    pipeline_name=${PIPELINE_TEST_NAME}
-
-    #    Verify Pipeline Run Deployment Is Successful    project_title=${PRJ_TITLE}
-    #    ...    workflow_name=${workflow_name}
+    Verify Pipeline Run Is Completed    ${PIPELINE_TEST_RUN_BASENAME}
 
     ODHDataSciencePipelines.Delete Pipeline Run       ${PIPELINE_TEST_RUN_BASENAME}    ${PIPELINE_TEST_NAME}
     ODHDataSciencePipelines.Delete Pipeline           ${PIPELINE_TEST_NAME}