Patternfly changes for gpu model serving #1123
Conversation
Signed-off-by: Tarun Kumar <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -18,12 +18,14 @@ | |||
| ${REPLICAS_PLUS_BTN_XP}= xpath=//div/button[@aria-label="Plus"] | |||
| ${REPLICAS_MIN_BTN_XP}= xpath=//div/button[@aria-label="Minus"] | |||
| ${SERVING_RUNTIME_NAME}= xpath=//input[@id="serving-runtime-name-input"] | |||
| ${SERVING_ACCELERATOR_DROPDOWN_XPATH}= xpath=//label[@for='modal-notebook-accelerator']/ancestor::div[@class='pf-c-form__group']/descendant::button | |||
| ${SERVING_ACCELERATOR_DROPDOWN_XPATH}= xpath=//label[@for='modal-notebook-accelerator']/ancestor::div[@class='pf-v5-c-form__group-control']/descendant::button | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
tarukumar
added
enhancements
|
#smoke : 4339 |
|
can u plz rebase the patch |
|
There was a problem hiding this comment.
LGTM, thank you.
One question - there are attempts to not to use the pf-v5 prefix as this may change due to the PatternFly version in the future again. Instead, something like contains(@class,"-table__action") is preferred, see e.g. #1117. WDYT?
|
@jstourac for now i will keep this and will send another pr which i am working on to have this fix. For now i need this pr to be merged to handle the other pr |
No description provided.