Fix "Click Action From Actions Menu" and CustomServingRuntime test #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Robot Results
|
bdattoma
force-pushed
the
2.6/ui-fixes
branch
from
99df75b to
0437118
Compare
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot
Fixed
Show fixed
Hide fixed
| Wait Until Page Contains Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]/td[@class="pf-v5-c-table__action"]/div/ul/li/button[text()="${action}"] | ||
| Click Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]/td[@class="pf-v5-c-table__action"]/div/ul/li/button[text()="${action}"] | ||
| Wait Until Page Contains Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]//td//li//*[text()="${action}"] | ||
| Click Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]//td//li//*[text()="${action}"] |
Check warning
Code scanning / Robocop
File has too many lines ({{ lines_count }}/{{max_allowed_count }}) Warning test
bdattoma
requested review from
FedeAlonso,
nehachopra27,
diegolovison,
jgarciao,
jiridanek,
manosnoam,
jiripetrlik and
jstourac
bdattoma
added
needs testing
diegolovison
previously approved these changes
Jan 15, 2024
|
PR Validation
|
jiridanek
reviewed
Jan 15, 2024
| @@ -837,9 +837,9 @@ Handle Deletion Confirmation Modal | |||
| Click Action From Actions Menu | |||
| [Documentation] Clicks an action from Actions menu (3-dots menu on the right) | |||
| [Arguments] ${item_title} ${action} ${item_type}=${NONE} | |||
| Click Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]/td[@class="pf-v5-c-table__action"]/div/button[@aria-label="Actions"] | |||
| Click Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]/td[contains(@class,"-table__action")]//button[@aria-label="Kebab toggle"] # robocop: disable | |||
There was a problem hiding this comment.
Note to self, for the future we should have keywords for clicking common paternfly UI elements. Locators of this style appear many times. @aria-label="Kebab toggle" is beginning to hound my dreams.
There was a problem hiding this comment.
Click Action From Actions Menu, like that
There was a problem hiding this comment.
yep I agree, that would help also reducing the code duplication. However I don't kow now from top of my head some more keywords like this one we could have. But if you find any, welcome to have it in a common place to be re-used
jiridanek
approved these changes
Jan 15, 2024
|
jiridanek
added a commit
to jiridanek/ods-ci
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Jiri Daněk <[email protected]>
jiridanek
added a commit
to jiridanek/ods-ci
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Jiri Daněk <[email protected]>
jiridanek
added a commit
to jiridanek/ods-ci
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Jiri Daněk <[email protected]>
jiridanek
added a commit
that referenced
this pull request
Jan 16, 2024
* Fix ODS-2206, ODS-2226 for ODH 2.6 The Pipelines-related UI has changed in the Dashboard Signed-off-by: Jiri Daněk <[email protected]> * fixup contains Signed-off-by: Jiri Daněk <[email protected]> * fixup paths Signed-off-by: Jiri Daněk <[email protected]> * fixup texts Signed-off-by: Jiri Daněk <[email protected]> * fixup use kebab menu locators from #1117 Signed-off-by: Jiri Daněk <[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
Verify RHODS Admins Can Delete A Custom Serving Runtime Templatewhich got broken after patternfly update.It involves fixing
Click Action From Actions Menukw