Fix #166: Add missing pygments css link #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
added
the
PR: work in progress
Blendify
changed the title
|
This will also be fixed by #467 |
ericholscher
approved these changes
Dec 3, 2017
|
Did you test the changes? Because I think that we are pulling some sass from wyrm that might be overriding this |
|
I figured you had tested it, no? It is in the Sphinx docs, so figured we should do it. Seems like putting it after the theme CSS would make sure it's supported. |
|
I have not tested but that is likely true but there might not be a need for
the wrym sass for syntax highlighting anymore
…On Sun, Dec 3, 2017 at 1:10 PM, Eric Holscher ***@***.***> wrote:
I figured you had tested it, no? It is in the Sphinx docs, so figured we
should do it. Seems like putting it after the theme CSS would make sure
it's supported.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#448 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOeua8raeJI5y1glk8RwPM1R5nh9aZyFks5s8uQdgaJpZM4Onf77>
.
--
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project
|
|
I will test again and open a second PR if other stuff needs to change
On Sun, Dec 3, 2017 at 1:17 PM, Aaron Carlisle <[email protected]>
wrote:
… I have not tested but that is likely true but there might not be a need
for the wrym sass for syntax highlighting anymore
On Sun, Dec 3, 2017 at 1:10 PM, Eric Holscher ***@***.***>
wrote:
> I figured you had tested it, no? It is in the Sphinx docs, so figured we
> should do it. Seems like putting it after the theme CSS would make sure
> it's supported.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#448 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AOeua8raeJI5y1glk8RwPM1R5nh9aZyFks5s8uQdgaJpZM4Onf77>
> .
>
--
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project
--
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project
|
This was referenced May 4, 2018
|
As reported in readthedocs/readthedocs.org#4050 (comment), one should set the background for or one adds a pygments style for sphinx-rtd :) edit: oh wait, |
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #166: Add missing pygments css link