Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#441 add initial version of styles for JS highlighting #444

Closed
wants to merge 1 commit into from

Conversation

TimKam
Copy link

@TimKam TimKam commented Jul 27, 2017

I added a first proposal for JavaScript highlighting. It's based on the default syntax highlighter of the Atom text editor.
However, I identified a set of issues with the JavaScript lexer of Pygments:

  • const should be class .kd
  • arrow function => and spread operator ... should be class .o
  • functions should get own class
  • all global variables and their properties should be added to class .nb
  • difference between names after var + let vs. const

I plan to create a fix for Pygments eventually.
The question is: Should we wait for a Pygments fix or merge the best we can get until then as soon as possible?

@Blendify
Copy link
Member

I plan to create a fix for Pygments eventually.
The question is: Should we wait for a Pygments fix or merge the best we can get until then as soon as possible?

I would rather see this fixed in Pygments itself rather complicating our theme. Plus this will allow others that do not use our theme to use this syntax highlighting style.

Note that currently, Payments does not work at all with the theme, #448 fixes this.

@TimKam
Copy link
Author

TimKam commented Jul 31, 2017

Ok, the missing style sheet link explains a lot ;-)
I'll try to fix the remaining issues in Pygments then and close this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants