Remove html5shiv
#1482
Remove html5shiv
#1482
Conversation
| @@ -263,13 +263,15 @@ | |||
| "version": "1.0.1", | |||
| "resolved": "https://registry.npmjs.org/ajv-errors/-/ajv-errors-1.0.1.tgz", | |||
| "integrity": "sha512-DCRfO/4nQ+89p/RK43i8Ezd41EqdGIU4ld7nGF8OQ14oc/we5rEntLCUa7+jrn3nn83BosfwZA0wb4pon2o8iQ==", | |||
| "dev": true | |||
| "dev": true, | |||
There was a problem hiding this comment.
Some changes to this file were merely caused by running npm install --lockfile-version 1. The full diff can be seen here. Lmk if this needs changing/reverting
|
This would be lovely to have -- we are blocked from using RTD by vulnerability policy and this PR would fix it. I'm not a Sphinx dev, but is there anything I can do to somehow help with merging this? |
|
Emily, I think it's better to voice your support and want on the issue page than on this PR itself, there are more participants there that will get comment notifications :) |
|
Unfortunately the support has withered now that I switched to Furo :/ |
|
@agjohnson I'd like to include this PR in 2.0 final since it's related with the drop of pretty old browsers support we mentioned there. It looks like a pretty simple change. |
There was a problem hiding this comment.
This change is safe, we've been in IE deprecation for a while.
However, this is another PR to probably hold off on merging until we finalize 2.0rc1, and we can treat 2.1 or 2.2 as the release to clean up more of these dependencies. Either way this should be low impact though.
|
This PR seems to be ready to merge now that we have released 2.x 🎉 |
|
Yup, this should be safe to merge now |
Resolves #1477