Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove html5shiv #1477

Closed
mix4242 opened this issue May 23, 2023 · 1 comment · Fixed by #1482
Closed

Remove html5shiv #1477

mix4242 opened this issue May 23, 2023 · 1 comment · Fixed by #1482

Comments

@mix4242
Copy link
Contributor

mix4242 commented May 23, 2023

Hi all. First, thank you for the theme. It's great!

I would like to propose the removal of the html5shiv library. I've seen it discussed in past when Modernizr was removed but html5shiv left to support IE. I see however from the supported browsers page that IE < 9 is no longer supported.

Further, html5shiv is a bit outdated, not having updates & it appears no development for a few years.

Lasty, there appears to be a vulnerability reported by some scanning tools. This was reported by one of our users from a JFrog scan:

html5shiv html5shiv-printshiv.js ownerDocument.createDocumentFragment() Function Arbitrary Code Execution		High	security	JFrog	html5shiv	3.4 ≤ Version ≤ 3.7.3		2021-05-20T19:55:08Z	html5shiv	9.3/CVSS:2.0/AV:N/AC:M/Au:N/C:C/I:C/A:C			XRAY-78889	FALSE	npm://html5shiv:3.7.3	npm://html5shiv	sha256__d6c54436e60bc608283ddf62185350ab36b1596a0a9f27758e8238ca86424b91.tar.gz/app/wwwprivate/help/_static/js/html5shiv.min.js	unknown
html5shiv html5shiv.js ownerDocument.createDocumentFragment() Function Arbitrary Code Execution		High	security	JFrog	html5shiv	3.4 ≤ Version ≤ 3.7.3		2021-05-20T19:55:08Z	html5shiv	9.3/CVSS:2.0/AV:N/AC:M/Au:N/C:C/I:C/A:C			XRAY-78890	FALSE	npm://html5shiv:3.7.3	npm://html5shiv	sha256__d6c54436e60bc608283ddf62185350ab36b1596a0a9f27758e8238ca86424b91.tar.gz/app/wwwprivate/help/_static/js/html5shiv.min.js	unknown

& there is also an open issue from SonarQube

Is it possible to remove this library? And if not, is there a way for me to exclude it during build? (atm I'm just trying to delete the lib files) Thanks!

@benjaoming
Copy link
Contributor

I agree with this! PR is most welcome 👍

We have 2 upcoming releases, 1.3.0 and 2.0.0, so there should be a possibility to release this. It doesn't seem to break anything, and the vulnerability seems to lend some importance to this.

@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Aug 22, 2023
@agjohnson agjohnson moved this from Planned to In progress in 📍Roadmap Aug 30, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in 📍Roadmap Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants