Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Pull Request Build on RTD shows as pending on GitHub #8177

Closed
jakirkham opened this issue May 12, 2021 · 3 comments · Fixed by #8296
Closed

Failed Pull Request Build on RTD shows as pending on GitHub #8177

jakirkham opened this issue May 12, 2021 · 3 comments · Fixed by #8296
Labels
Bug A bug

Comments

@jakirkham
Copy link
Contributor

Currently when a pull request build fails on RTD. It appears the GitHub status for that pull request is not updated as having failed, but remains marked as pending.

Details

Expected Result

Once the RTD pull request build fails, it would be good to have the GitHub pull request status also marked as having failed.

Actual Result

Here's a screenshot from RTD for the pull request. Note the build has failed

Screen Shot 2021-05-12 at 12 15 34 PM

Here's the screenshot of the GitHub pull request's CI statuses. Note RTD is shown as still pending

Screen Shot 2021-05-12 at 12 15 13 PM

@jakirkham
Copy link
Contributor Author

(apologies if this was in another issue somewhere. was unable to find it after searching. also feel free to move if this is not the right repo for this issue)

@stsewd stsewd added the Bug A bug label May 13, 2021
@humitos
Copy link
Member

humitos commented Jun 3, 2021

This may be a temporary failure when contacting GitHub. We could probably re-try the task up to 3 times if it fails at

def send_build_status(build_pk, commit, status, link_to_build=False):
(it returns False)

humitos added a commit that referenced this issue Jun 29, 2021
Sometimes it happens that the task fail for some reason and people don't get the
PR status updated for RTD build. This commit adds a retry up to 3 times to avoid
these cases.

Closes #8177
@humitos
Copy link
Member

humitos commented Jun 29, 2021

This seems to be a temporal issue. I found in our logs that we are reporting the status correctly to github:

Jun 28 16:22:59 INFO Build status report sent correctly using an user account. project=ucx-py build=14115644 status=pending commit=f771d837eb7f6e361205a18c2cbcf30df6f42d15 user=quasiben

Jun 28 16:26:40 INFO Build status report sent correctly using an user account. project=ucx-py build=14115644 status=success commit=f771d837eb7f6e361205a18c2cbcf30df6f42d15 user=quasiben 

I opened a PR that retries up to 3 times if it fails for any reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants