-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed Pull Request Build on RTD shows as pending on GitHub #8177
Comments
(apologies if this was in another issue somewhere. was unable to find it after searching. also feel free to move if this is not the right repo for this issue) |
This may be a temporary failure when contacting GitHub. We could probably re-try the task up to 3 times if it fails at readthedocs.org/readthedocs/projects/tasks.py Line 1880 in f32ba4d
False )
|
Sometimes it happens that the task fail for some reason and people don't get the PR status updated for RTD build. This commit adds a retry up to 3 times to avoid these cases. Closes #8177
This seems to be a temporal issue. I found in our logs that we are reporting the status correctly to github:
I opened a PR that retries up to 3 times if it fails for any reason. |
Currently when a pull request build fails on RTD. It appears the GitHub status for that pull request is not updated as having failed, but remains marked as pending.
Details
libnuma
on RTD rapidsai/ucx-py#734Expected Result
Once the RTD pull request build fails, it would be good to have the GitHub pull request status also marked as having failed.
Actual Result
Here's a screenshot from RTD for the pull request. Note the build has failed
Here's the screenshot of the GitHub pull request's CI statuses. Note RTD is shown as still pending
The text was updated successfully, but these errors were encountered: