Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libnuma on RTD #734

Merged
merged 7 commits into from
May 18, 2021

Conversation

jakirkham
Copy link
Member

Uses the functionality recently added to RTD in PR ( readthedocs/readthedocs.org#8065 ) by following this example to install libnuma on RTD.

@pentschev
Copy link
Member

Nice!

@jakirkham jakirkham force-pushed the rtd_install_libnuma branch 3 times, most recently from b67c85f to ee9e940 Compare May 12, 2021 18:45
@jakirkham jakirkham force-pushed the rtd_install_libnuma branch from ee9e940 to 1a55d6e Compare May 12, 2021 18:48
@jakirkham
Copy link
Member Author

JFYI RTD needs to still deploy the change on their end, which is scheduled for next Tuesday afternoon ( readthedocs/readthedocs.org#8065 (comment) ).

Also this feature requires adopting a new RTD config spec version ( readthedocs/readthedocs.org#8065 (comment) ). So have made those changes above and confirmed those work before adding apt packages. The last commit adds the apt packages, which won't work for now, but should work next week (as noted above).

@pentschev
Copy link
Member

Sure, let's wait for that. Thanks @jakirkham for this! 😄

@jakirkham
Copy link
Member Author

jakirkham commented May 18, 2021

Looks like RTD has deployed the change. Build is running. Let's see how it goes 🙂

@jakirkham jakirkham force-pushed the rtd_install_libnuma branch from 3d39b5d to 6674737 Compare May 18, 2021 17:07
@jakirkham jakirkham marked this pull request as ready for review May 18, 2021 17:18
@jakirkham
Copy link
Member Author

Looks like it worked! 🎉

Screen Shot 2021-05-18 at 10 18 41 AM

@quasiben
Copy link
Member

Thanks @jakirkham !

@quasiben
Copy link
Member

@gpucibot merge

@jakirkham jakirkham merged commit 504ba8e into rapidsai:branch-21.06 May 18, 2021
@jakirkham jakirkham deleted the rtd_install_libnuma branch May 18, 2021 17:29
@jakirkham
Copy link
Member Author

jakirkham commented May 18, 2021

I don't think the bot works on this repo yet. So went ahead and merged manually (since it seems like we are ok with the changes)

Edit: If I did missing anything though, happy to revisit in a fresh PR

@pentschev
Copy link
Member

Thanks @jakirkham , great work! 😄

@jakirkham
Copy link
Member Author

RTD shared this as an example use case in their recent blogpost on this new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants