Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to re-trigger a build from the build page #6524

Closed
stsewd opened this issue Jan 14, 2020 · 5 comments · Fixed by #6995 or #8227
Closed

Allow to re-trigger a build from the build page #6524

stsewd opened this issue Jan 14, 2020 · 5 comments · Fixed by #6995 or #8227
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Jan 14, 2020

This is mainly for builds from a pull request (maybe would be good to add this to normal builds too?), sometimes the build fails for reasons that aren't related to the PR like https://readthedocs.org/projects/docs/builds/10259706/.

The status of the PR would be marked with the red X because of that. Travis and other services allow you to trigger a new build to refresh the status.

Currently, the only way to trigger a new build is by making another commit.
We could allow to re-trigger a build only on unsuccessful builds or maybe in all builds.

@stsewd stsewd added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Jan 14, 2020
@stsewd
Copy link
Member Author

stsewd commented Jan 14, 2020

The link gives 404 now because we delete all builds when the PR is merged/closed :D

@saadmk11
Copy link
Member

I think we can show a Restart Build button on the build detail page for the External versions and it should be only available to the maintainers of the project.

@pllim
Copy link
Contributor

pllim commented Jan 25, 2020

Hello. I was looking for this feature as well.

FWIW, I think allowing trigger for both failing and successful builds is useful. This is because sometimes as a maintainer, I want to know if new upstream release on PyPI would break an already successful PR build.

Also would be nice to have a "wipe cache" option. Currently some builds are failing due to invalid cache for pip 20.0. A wipe is necessary before rebuild.

@ericholscher
Copy link
Member

This is really useful for the PR builder. I think we need to figure out a good way to ship this 👍

ericholscher added a commit that referenced this issue Apr 29, 2020
This is most useful for PR builds,
but I've enabled it for all builds currently.
It might make sense to only enable it for PR builds,
or other builds where we care about rebuilding a specific commit.

Fixes #6524
ericholscher added a commit that referenced this issue May 18, 2020
This is most useful for PR builds,
but I've enabled it for all builds currently.
It might make sense to only enable it for PR builds,
or other builds where we care about rebuilding a specific commit.

Fixes #6524
@chaen
Copy link

chaen commented Mar 25, 2021

+1 on the feature. We are hit by this problem when the build crashes (e.g. Command killed due to excessive memory consumption) and it is a pity to have to re-run 50 other tests that passed just because of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
5 participants